Changed expected datatype of various options to number #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arenard
changed the title
arenard
force-pushed
the
fix-options-datatypes
branch
from
4493364 to
205d6d9
Compare
`auto_commit_interval_ms`, `connections_max_idle_ms`, `fetch_max_bytes`, `fetch_max_wait_ms`, `fetch_min_bytes`, `heartbeat_interval_ms`, `max_partition_fetch_bytes`, `max_poll_interval_ms`, `max_poll_records`, `metadata_max_age_ms`, `receive_buffer_bytes`, `reconnect_backoff_ms`, `request_timeout_ms`, `retry_backoff_ms`, `send_buffer_bytes`, `session_timeout_ms`
arenard
force-pushed
the
fix-options-datatypes
branch
from
205d6d9 to
e6de3dd
Compare
robbavey
requested changes
Mar 13, 2019
There was a problem hiding this comment.
@arenard - thanks for the contribution. This looks like a good change, just a couple of asks:
The change is backwardly compatible, so no need to do a major version bump, just the patch version can be bumped.
Can we add some tests to verify the changes?
karenzone
reviewed
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These options are mapped to numeric values in kafka configuration:
auto_commit_interval_ms,connections_max_idle_ms,fetch_max_bytes,fetch_max_wait_ms,fetch_min_bytes,heartbeat_interval_ms,max_partition_fetch_bytes,max_poll_interval_ms,max_poll_records,metadata_max_age_ms,receive_buffer_bytes,reconnect_backoff_ms,request_timeout_ms,retry_backoff_ms,send_buffer_bytes,session_timeout_ms