Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize schema evaluation #1

Open
6 of 12 tasks
loicalleyne opened this issue Nov 2, 2024 · 0 comments
Open
6 of 12 tasks

Optimize schema evaluation #1

loicalleyne opened this issue Nov 2, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@loicalleyne
Copy link
Owner

loicalleyne commented Nov 2, 2024 •
edited
Loading

  • generate arrow fields only at Schema()
    • ordered map[string]*fieldPos of evaluated dotpaths in Bodkin
    • store arrow type ids
    • sort dotpath keys by length descending and create fields towards the root
  • skip redundant type evaluations wherever possible
    • map[string]*fieldPos of "type unknown" dotpaths
    • funcs to list and count "unknown type" fields
    • skip empty strings when possible
    • ordered map[arrow.TypeID]struct{} with field type history
    • fieldPos.freeze bool upgraded scalar types and skip evaluation in unify
    • skip frozen and unupgradeable types (worry about union types later)
  • UnifyAtPath()
@loicalleyne loicalleyne added the enhancement New feature or request label Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@loicalleyne