Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to remove mob killing sound effect #12

Open
wincowski opened this issue Dec 13, 2023 · 6 comments
Open

How to remove mob killing sound effect #12

wincowski opened this issue Dec 13, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@wincowski
Copy link

Describe your suggestion

Minecraft Java Fabric 1.20.1
Extra Sounds 2.3.1 (lonefelidae16-build.1)

The problem I have is sound-like lighting after I kill a mob, it doesn't matter which mob I killed like a cow or skeleton. I can control this sound from extra sound settings > actions > off. But these settings control items, block interactions, and entity events. Do you know how I can disable only this lighting sound?

Additional context

latest.log

@wincowski wincowski added the enhancement New feature or request label Dec 13, 2023
@lonefelidae16
Copy link
Owner

Would you like to build this project yourself? The affected mixin you mentioned is action.LivingEntityMixin in extrasounds.mixins.json#12. Remove this line and build it. Also, you can refer to the build instructions on the wiki. Please checkout refs/tags/stable/1.20.1-build.1 instead of refs/heads/dev.

Otherwise, turn off Action sound.

@lonefelidae16
Copy link
Owner

Another option: use a resource pack to replace the poof sound with a muted sound source.

tested on 1.20.1: ExtraSounds-muteEntityDeath.zip

I thought I could just rewrite sounds.json and set volume to 0, but Minecraft gives me a warning: IllegalArgumentException: Invalid volume, and it won’t be muted. If I described the value as close to zero as possible, e.g. 0.00001, it’ll be pseudo-muted, but it’s not completely silent.
So, if you’re going to use a resource pack, you might as well replace it with a muted sound source.

@wincowski
Copy link
Author

wincowski commented Dec 18, 2023

Would you like to build this project yourself? The affected mixin you mentioned is action.LivingEntityMixin in extrasounds.mixins.json#12. Remove this line and build it. Also, you can refer to the build instructions on the wiki. Please checkout refs/tags/stable/1.20.1-build.1 instead of refs/heads/dev.

Otherwise, turn off Action sound.

I applied this one, removed the sound line from JSON, and added it to the config file but still, this sound is in the game. I don't want to offend you but this sound is so annoying for me

@lonefelidae16
Copy link
Owner

I applied this one, removed the sound line from JSON, and added it to the config file but still, this sound is in the game.

There are two JSON files, sorry for the lack of clarity. Modifying sounds.json in assets directory does not make any sense for revisions prior to 6e40e3e.

If you wish to modify this repo and create a Jar, please edit extrasounds.mixins.json as above, or comment out action.LivingEntityMixin#36.

If you wish to use Minecraft’s resource pack feature, replace the poof sound in assets/extrasounds/sounds/entity/poof.ogg with a silent sound source as shown in the attached zip file. This can be applied to ogg files placed in Jar as well as to packs placed in the resourcepacks directory in your game.

@wincowski
Copy link
Author

I applied this one, removed the sound line from JSON, and added it to the config file but still, this sound is in the game.

There are two JSON files, sorry for the lack of clarity. Modifying sounds.json in assets directory does not make any sense for revisions prior to 6e40e3e.

If you wish to modify this repo and create a Jar, please edit extrasounds.mixins.json as above, or comment out action.LivingEntityMixin#36.

If you wish to use Minecraft’s resource pack feature, replace the poof sound in assets/extrasounds/sounds/entity/poof.ogg with a silent sound source as shown in the attached zip file. This can be applied to ogg files placed in Jar as well as to packs placed in the resourcepacks directory in your game.

Thanks for your answers and help but I don't understand this stuff very much I mean it's so confusing for me. If it is easy for you can you share a file and I can try it maybe?

@lonefelidae16
Copy link
Owner

Thanks for your answers and help but I don't understand this stuff very much I mean it's so confusing for me. If it is easy for you can you share a file and I can try it maybe?

Sure, but this would be a special opportunity to provide a customized Jar. It’ll tire me out in the future as it needs continual updating to adapt to your suggestion. I’d like to avoid individual correspondence as much as possible.

extrasounds-2.3.1+1.20.1~6bff3e0.jar.zip

Please consider applying this resourcepack to newer versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants