-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENHANCEMENT] All three.js examples displayed in iframes should be hosted locally #5
Comments
@looeee I think just download threejs, and put files into web server, |
Yeah, it's a nice and simple solution. Unfortunately, the examples and docs are not in the NPM package so this would require yet another copy of three to be included. There are a couple of additional reasons that I want to include the examples locally that I forgot to mention above:
There's no need for this menu when showing the example in the book so I would like to remove it.
For these reasons I'd prefer to include these examples under |
FYI the actual site is running on a DigitalOcean droplet using nginx as the server. So serving any kind of static files is trivial to set up, but to keep things simple we should make sure all files are served from within the |
Make a script to resolve these point isnt tricky, but it seems that the work to modify content directly is not very large. |
I think doing this by hand is ok, there's no need for a script. |
Currently, many of the official three.js examples are included as iframes throughout the book. These slow down the page load and upstream changes on the three.js repo may unexpectedly break something (if an example gets deleted from the three.js repo, for example).
{{< iframe src="https://threejs.org/examples/webgl_materials_envmaps.html" height="500" title="Image Based Lighting (IBL) in action" caption="Image Based Lighting (IBL): the scene background is reflected on the sphere" >}}
It would be better to extract the code from these and include them in this repo.
The text was updated successfully, but these errors were encountered: