Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamping repo, suggestions welcome! #23

Open
1 task
loong opened this issue Oct 9, 2022 · 1 comment
Open
1 task

Revamping repo, suggestions welcome! #23

loong opened this issue Oct 9, 2022 · 1 comment

Comments

@loong
Copy link
Owner

loong commented Oct 9, 2022

Hello everyone,

I'm grateful to come back to this project and see we have passed 500 stars! This project was originally made for fun to show at a Go Meetup in Hsinchu, Taiwan (where only 2 other people showed up).

This repo def deserves some revamping! Most of this was made back in 2016, and Go as a language has evolved since then!

Let me know if you have any wishes! I keep a list of ideas below.

Ideas

  • Introduce go modules
@dangdennis
Copy link

This has been a great refresher. Thanks @loong.

Go modules is a good next step, and fixing any lint errors.

In 0-limit-crawler, there are a couple warnings.

  1. use time.Since(start)
  2. according to testinggoroutine, call to t.FailNow should be in the main test goroutine. i'm unsure how to fix though.

In 1-producer-consumer, yeah it'd be nice for someone revisiting this to simply run go run main.go instead of remembering to run go run main.go mockstream.go.

I'll report any more possible changes when I'm done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants