Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase privacy of guest email addresses #178

Open
cass-dlcm opened this issue Dec 27, 2024 · 2 comments
Open

Increase privacy of guest email addresses #178

cass-dlcm opened this issue Dec 27, 2024 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@cass-dlcm
Copy link

cass-dlcm commented Dec 27, 2024

In the current implementation, when an event is updated, it sends a single email out to all people who included an email address on their RSVP.

While the email addresses aren't publicly displayed on the event page, the email sent when an event is modified includes every email address of event attendees on the "TO:" line, meaning that all recipients of the email can see each other's email addresses.

I think the default behavior of the application should be to use "BCC" for each participant, and allow participants to opt-in to being included on the "TO" line for these emails.

Showing the current behavior of the application, I've included a screenshot. This screenshot is of the "FROM" and "TO" lines of an event update email for an event where 6 participants provided their email addresses when signing up. I've censored the username portions of each email address to be the first and last letter only, and censored personal domains to first and last letter of domain + full TLD.
Screenshot 2024-12-27 at 9 43 54 AM

@lowercasename lowercasename added bug Something isn't working good first issue Good for newcomers labels Jan 1, 2025
@lowercasename
Copy link
Owner

Hi, thanks for the detailed report! This is a very valid note and should definitely be fixed. I don't have any spare time at the moment unfortunately but this is a great first issue for anyone who wants to get involved in Gathio. ❤️

@cass-dlcm
Copy link
Author

cass-dlcm commented Jan 3, 2025

I forked the repo onto my git server, made the changes.
I've tested for the nodemailer functionality, but I don't have a sendgrid API key at the moment to use for testing that integration.

The commit I'm proposing to be upstreamed. (forgejo.kasanwa.name)

Direct link for a patch file (forgejo.kasanwa.name, downloads file)

If you feel the changes are ready to include, here's the instructions.
To apply the patch, use git am --signoff e3d3fb1455.patch, and then push the resulting commit.
The am is the appropriate git subcommand for applying the patch in a way that preserves commit message and author.
Note that if you want to change the commit message, you must edit the 5th line of the patch, which starts with the label Subject: .
That part must be preserved, and what is put after is the commit message.
You can do multi-line commit messages, as it knows where the message ends and where the next part of the patch begins by the --- on its own line after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants