Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23 create edges between components #72

Merged
merged 10 commits into from
Jan 13, 2025

Conversation

kurunbelemir
Copy link
Collaborator

Checklist

  • I linked PR with a related issue
  • I added multiple screenshots/screencasts of my UI changes

Description

  • Custom 7 edges are created and displayed in the canvas which are:
    bi-association, uni-association, composition, aggregation, dependency, inheritance,realization.

Issue: #23

  • Default edge type is set to bi-association line.
  • Edges are reconnect able and adjustable to orientation.

Steps for Testing

You can change the connection between the edges to see whether there is a bug in the custom markers, their connection points.
You can create new edges but only bi-association (Simple line) is available. Edit edge will be included in another issue.

Screenshots

image

@kurunbelemir kurunbelemir added the enhancement New feature or request label Jan 13, 2025
@kurunbelemir kurunbelemir self-assigned this Jan 13, 2025
@kurunbelemir kurunbelemir linked an issue Jan 13, 2025 that may be closed by this pull request
@kurunbelemir kurunbelemir requested a review from egenerse January 13, 2025 19:30
Copy link
Collaborator

@egenerse egenerse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the pull request with the suggested changes? Feel free to reach out to me if you need any assistance or have questions.

@kurunbelemir kurunbelemir requested a review from egenerse January 13, 2025 21:27
Copy link
Collaborator

@egenerse egenerse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work! after these small changes, we can merge :shipit: 🚀 🚀

Comment on lines +23 to +24
import { useConnect } from "./hooks/useConnect"
import { useReconnect } from "./hooks/useReconnect"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please import from './hooks'
you can export these new hooks from here https://github.com/ls1intum/Apollon2/blob/main/library/lib/hooks/index.ts

@kurunbelemir kurunbelemir merged commit 2bdad1e into main Jan 13, 2025
2 checks passed
@kurunbelemir kurunbelemir deleted the 23-create-edges-between-components branch January 13, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Create Edges between Components
2 participants