feat: 24 see components from sidebar #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurunbelemir
requested changes
Dec 30, 2024
kurunbelemir
requested changes
Dec 30, 2024
kurunbelemir
requested changes
Dec 30, 2024
There was a problem hiding this comment.
Also Color Description looks odd. When you click for dragging the element, It creates bigger outer box. Then when you drop, color description element size gets bigger. When I checked current Apollon version, we need to make smaller color description elements like you displayed in the canvas.
I saw these 2 bugs and fixed but didnt push. I am looking into the safari bug now |
kurunbelemir
requested changes
Jan 2, 2025
There was a problem hiding this comment.
ApollonDragandDropBug.mp4
Is this drag and drop correct? It looks little jumpy to me. After getting elements from sidebar, changing placement in the canvas works perfectly. Only the first drag and drop looks weird.
Also Left edges of the elements looks grey while other edges are black. Do you know the reason?
kurunbelemir
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Motivation and Context
This PR completes #24
Description
Sidebar is added and sidebar elements can be added into canvas
SVGs folder is created for reusability to render elements in Canvas and also in Sidebar
Steps for Testing
Screenshots