Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

32 create new diagram from template #88

Merged
merged 10 commits into from
Jan 28, 2025
Merged

32 create new diagram from template #88

merged 10 commits into from
Jan 28, 2025

Conversation

egenerse
Copy link
Collaborator

Checklist

  • I linked PR with a related issue
  • I added multiple screenshots/screencasts of my UI changes

Motivation and Context

Users can easily create a template to see basic patterns

This PR completes #32

Description

New modal is created so user can select template
Static JSON files are added to web app to create templates

Steps for Testing

  1. Navigate to File in navbar and select "Start from Template"
  2. Select different templates
  3. Observe template is created on canvas

Screenshots

Screen.Recording.2025-01-27.at.22.09.17.mov

@egenerse egenerse requested a review from kurunbelemir January 27, 2025 21:13
@egenerse egenerse self-assigned this Jan 27, 2025
@egenerse egenerse linked an issue Jan 27, 2025 that may be closed by this pull request
Create New Diagram From Template #32
Closed
kurunbelemir
kurunbelemir requested changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@kurunbelemir kurunbelemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works just small typo in Observer
image

@egenerse egenerse requested a review from kurunbelemir January 28, 2025 06:52
kurunbelemir
kurunbelemir approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@kurunbelemir kurunbelemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@egenerse egenerse merged commit 21200e8 into main Jan 28, 2025
2 checks passed
@egenerse egenerse deleted the 32-create-new-diagram-from-template branch January 28, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurunbelemir kurunbelemir kurunbelemir approved these changes

Assignees

@egenerse egenerse

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create New Diagram From Template
2 participants
@egenerse @kurunbelemir