Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 41 create eslint configurations for library webapp and server #42

Merged

Conversation

egenerse
Copy link
Collaborator

This PR solves #41

Project static code quality is checked by eslint rules.
npm run lint is added to recommit husky hook, so that before committing rules will be checked by eslint.

A developer can also run npm run lint or npm run lint:fix from the root to check the linting status of the project anytime

@egenerse egenerse self-assigned this Dec 17, 2024
@egenerse egenerse linked an issue Dec 17, 2024 that may be closed by this pull request
Copy link
Collaborator

@kurunbelemir kurunbelemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also include npm run lint in the Readme file. I think this is useful information that we need to mention in Readme.

@egenerse egenerse merged commit deecb05 into main Dec 17, 2024
1 check passed
@egenerse egenerse deleted the 41-create-eslint-configurations-for-library-webapp-and-server branch December 17, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Eslint configurations for library, webapp and server
2 participants