Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

70 extent package to have children recursively #79

Merged
merged 14 commits into from
Jan 20, 2025

Conversation

egenerse
Copy link
Collaborator

@egenerse egenerse commented Jan 19, 2025

Checklist

  • I linked PR with a related issue
  • I added multiple screenshots/screencasts of my UI changes

Motivation and Context

This PR completes #70

Description

  • Package node can have multiple child nodes
  • A Child node can be extracted from the parent node
  • A Child node can be added as a child of another node
  • Drag and drop actions on nodes can resize parent and their parent nodes recursively
  • Increasing one node's width and height resized its parent's width and height
  • Package node's name can be edited from a popover

Steps for Testing

  • Add Package node to canvas
  • Add another node from side node into package
  • If cursor is on the package element, new node should be added as a child of the package node.
  • If added node causes a overflow, package node should resize to cover
  • Add extra and recursive package nodes
  • Drag nodes from one package to another
  • Observe parents are changing.
  • When a node is a child of another node, during drag event of a parent, all of its child nodes should move with the parent
  • Select one node element and edit it's name from popover

Screenshots

Screen.Recording.2025-01-20.at.00.17.26.mov

@egenerse egenerse linked an issue Jan 19, 2025 that may be closed by this pull request
@egenerse egenerse requested a review from kurunbelemir January 19, 2025 16:40
@egenerse egenerse self-assigned this Jan 19, 2025
Copy link
Collaborator

@kurunbelemir kurunbelemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

  1. On safari it looks like edges are not shown correctly.
  2. Once I put the element inside the package, I can't move from the inside of the package.

@egenerse egenerse requested a review from kurunbelemir January 19, 2025 23:20
Copy link
Collaborator

@kurunbelemir kurunbelemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I tried to add another class diagram element inside the package, resizing actually worked correctly however because of the padding it looks like it is not working correctly.
image

@egenerse
Copy link
Collaborator Author

When I tried to add another class diagram element inside the package, resizing actually worked correctly however because of the padding it looks like it is not working correctly. image

This happens because the package is an SVG element containing 2 boxes. There could be some workaround, but it affects Node sizes as well. This should not be our focus. Current Apollon also handle this like this

Screenshot 2025-01-20 at 22 19 18

@egenerse egenerse merged commit 9490500 into main Jan 20, 2025
2 checks passed
@egenerse egenerse deleted the 70-extent-package-to-have-children-recursively branch January 20, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extent Package to have children recursively
2 participants