Hotfix Update Marker Ends to Make Pixel Perfect #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kurunbelemir newly created edges doesn't follow this marker end rule Screen.Recording.2025-01-27.at.15.38.07.mov |
You are right, BiAssociation Edge wasnt updated earlier, now I fixed it. |
egenerse
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a gap between source and target ends of the paths.
This PR is created in order to resolve issue and make the ends pixel perfect.
Checklist
Motivation and Context
Issue is the gap between the source and target ends.
Handles was creating gaps between nodes and paths.
This PR completes https://github.com/ls1intum/Apollon2/issues/xx
Description
I have updated handles and marker paddings, so that marker ends and start of the path would be directly connected to node.
Steps for Testing
Screenshots