From 2be3a49c5917f71b9c0fdedf689a85fa248f6b21 Mon Sep 17 00:00:00 2001
From: Yusra AlSayyad <yusra@astro.princeton.edu>
Date: Thu, 31 Oct 2024 10:43:34 -0700
Subject: [PATCH] Change default to assume preSources used for matching

Use isolated_star_presources for matches and sourceTable_visit
for measurements.
---
 pipelines/matchedVisitQualityCore.yaml                        | 2 --
 python/lsst/analysis/tools/atools/astrometricRepeatability.py | 3 ++-
 .../analysis/tools/tasks/associatedSourcesTractAnalysis.py    | 4 ++--
 python/lsst/analysis/tools/tasks/sourceObjectTableAnalysis.py | 2 +-
 4 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/pipelines/matchedVisitQualityCore.yaml b/pipelines/matchedVisitQualityCore.yaml
index a88b17d0e..96ad889db 100644
--- a/pipelines/matchedVisitQualityCore.yaml
+++ b/pipelines/matchedVisitQualityCore.yaml
@@ -88,8 +88,6 @@ tasks:
     config:
       connections.sourceCatalogs: preSourceTable_visit
       connections.outputName: matchedPreVisitCore
-      connections.associatedSources: isolated_star_presources
-      connections.associatedSourcesInputName: isolated_star_presources
       # Proper motion catalogs are not available for `preSourceTables`
       applyAstrometricCorrections: false
       atools.stellarAstrometricSelfRepeatabilityRA: AstrometricRepeatability
diff --git a/python/lsst/analysis/tools/atools/astrometricRepeatability.py b/python/lsst/analysis/tools/atools/astrometricRepeatability.py
index f2d9f1076..0efdfdba1 100644
--- a/python/lsst/analysis/tools/atools/astrometricRepeatability.py
+++ b/python/lsst/analysis/tools/atools/astrometricRepeatability.py
@@ -219,7 +219,8 @@ def setDefaults(self):
         self.prep.selectors.bandSelector = BandSelector()
         # Following what was done in faro, only sources with S/N between 50
         # and 50000 are included. The other filtering that was done in faro
-        # is now covered by only including sources from isolated_star_sources.
+        # is now covered by only including sources from
+        # isolated_star_presources.
         self.prep.selectors.snSelector = SnSelector()
         self.prep.selectors.snSelector.threshold = 50
         self.prep.selectors.snSelector.maxSN = 50000
diff --git a/python/lsst/analysis/tools/tasks/associatedSourcesTractAnalysis.py b/python/lsst/analysis/tools/tasks/associatedSourcesTractAnalysis.py
index 8e478aeaa..77f7ac51e 100644
--- a/python/lsst/analysis/tools/tasks/associatedSourcesTractAnalysis.py
+++ b/python/lsst/analysis/tools/tasks/associatedSourcesTractAnalysis.py
@@ -42,8 +42,8 @@ class AssociatedSourcesTractAnalysisConnections(
     AnalysisBaseConnections,
     dimensions=("skymap", "tract", "instrument"),
     defaultTemplates={
-        "outputName": "isolated_star_sources",
-        "associatedSourcesInputName": "isolated_star_sources",
+        "outputName": "isolated_star_presources",
+        "associatedSourcesInputName": "isolated_star_presources",
     },
 ):
     sourceCatalogs = ct.Input(
diff --git a/python/lsst/analysis/tools/tasks/sourceObjectTableAnalysis.py b/python/lsst/analysis/tools/tasks/sourceObjectTableAnalysis.py
index 2cb28aa79..b8d52af2d 100644
--- a/python/lsst/analysis/tools/tasks/sourceObjectTableAnalysis.py
+++ b/python/lsst/analysis/tools/tasks/sourceObjectTableAnalysis.py
@@ -147,7 +147,7 @@ class SourceObjectTableAnalysisConnections(
     defaultTemplates={
         "inputName": "sourceTable_visit",
         "inputCoaddName": "deep",
-        "associatedSourcesInputName": "isolated_star_sources",
+        "associatedSourcesInputName": "isolated_star_presources",
         "outputName": "sourceObjectTable",
     },
 ):