Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK Version #118

Open
tgwhite opened this issue Nov 2, 2015 · 1 comment
Open

SDK Version #118

tgwhite opened this issue Nov 2, 2015 · 1 comment

Comments

@tgwhite
Copy link

tgwhite commented Nov 2, 2015

I'm entirely new to the Facebook API and I thought I would give this module a shot for easier integration with the SDK.

I noticed that the SDK is currently >= 2.4 and I didn't see anything in example usage that indicated and SDK version parameter so I took a look at the source at it looks like it's hard coded to v2.0.

Is this likely to cause any problems? Can this be generalized to use the latest SDK version or at least accept a parameter that allows one to choose?

From dist/angular-facebook.js:

 /**
         * SDK version
         */
        settings.version = 'v2.0';

        this.setSdkVersion = function(version) {
          settings.version = version;
        };

        this.getSdkVersion = function() {
          return settings.version;
        };
@Yurko-Fedoriv
Copy link

You can set SDK version like this.

angular.module('app')
    .config(function config(FacebookProvider) {
        FacebookProvider.init('000000000000000');
        FacebookProvider.setSdkVersion('v2.5');
    })

I came here to say, that 2.0 version actually did not work for me at all, so the default value better be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants