Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Password-protected AES-256 encrypted pastes #33

Open
1 task done
jackdorland opened this issue Jun 3, 2020 · 5 comments
Open
1 task done

feat: Password-protected AES-256 encrypted pastes #33

jackdorland opened this issue Jun 3, 2020 · 5 comments
Assignees
Labels
☄️ enhancement New feature or request
Milestone

Comments

@jackdorland
Copy link
Contributor

jackdorland commented Jun 3, 2020

Please check the box if you understand that this repo is only for server-side backend issues. Please write issues related to the frontend or cli client in their respective repositories:

  • I understand.

Is your feature request related to a problem? Please describe.

N/A

Describe the solution you'd like

When pastes are uploaded, perhaps through a /encrypt endpoint, you would need to specify a password in the query parameters (or multipart form value). The server would then hash the password, salt it, encrypt the paste, and return the ID. No other data will be stored on the server other than the hash of the password.

Describe alternatives you've considered

N/A

Additional context

@jackdorland jackdorland added the ☄️ enhancement New feature or request label Jun 3, 2020
@jackdorland jackdorland pinned this issue Jun 3, 2020
@jackdorland jackdorland modified the milestones: Alpha v0.1.0, RC 1.0.0 Jun 4, 2020
@jackdorland jackdorland unpinned this issue Jun 4, 2020
@lukewhrit lukewhrit reopened this Aug 12, 2020
@lukewhrit lukewhrit reopened this Aug 21, 2020
@lukewhrit lukewhrit reopened this Aug 29, 2020
Repository owner deleted a comment from jackdorland Aug 29, 2020
@github-actions github-actions bot closed this as completed Dec 7, 2020
@lukewhrit lukewhrit reopened this Dec 7, 2020
@lukewhrit lukewhrit reopened this Dec 15, 2020
@lukewhrit lukewhrit reopened this Dec 23, 2020
@lukewhrit lukewhrit reopened this Dec 31, 2020
@lukewhrit lukewhrit moved this to ☄️ Features in Spacebin Jul 6, 2024
@lukewhrit lukewhrit moved this from ☄️ Features to 🐛 Bugs / QOL in Spacebin Jul 6, 2024
@lukewhrit lukewhrit moved this from 🐛 Bugs / QOL to ☄️ Features in Spacebin Jul 7, 2024
@lukewhrit lukewhrit modified the milestones: Release 1.0.0, v1.1.0 Jul 8, 2024
@lukewhrit lukewhrit self-assigned this Jul 8, 2024
@tarumes
Copy link

tarumes commented Nov 12, 2024

do it in javascript only so the server dont need to know anything about the encryption
and the password can be part of the url
scheme://domain.tld/key#password

@lukewhrit
Copy link
Owner

lukewhrit commented Nov 14, 2024

do it in javascript only so the server dont need to know anything about the encryption and the password can be part of the url scheme://domain.tld/key#password

@tarumes

Maybe- one of the original goals of Spacebin was to be as free of JavaScript as possible but it may be impossible to stick to that. Additionally, wouldn't it be more secure to do it server-side?

@tarumes
Copy link

tarumes commented Nov 14, 2024

nope the whole point of encryption is that no one knows the password not even the server

and having protected pastes just make the IDs longer and put in rate limits it results in the same as a password
its just harder to guess

@tarumes
Copy link

tarumes commented Nov 14, 2024

I forgot to mention the server only receives the part before the #, meaning anything after it isn’t sent to the server.
so only the persons with the correct string after the # can decrypt the document

@lukewhrit
Copy link
Owner

Yeah, I really meant that having the encryption/decryption logic on the client side might mean it's able to be bypassed. Also, if the password were in the URL it would be seen by the server that hosts the website (In Spacebin's case it's combined w/ the API) so that it could fulfill the request.

I will keep your suggestion in mind while researching the best way to implement this feature.

Repository owner deleted a comment from github-actions bot Nov 16, 2024
Repository owner deleted a comment from github-actions bot Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☄️ enhancement New feature or request
Projects
Status: ☄️ Features
Development

No branches or pull requests

3 participants