Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve IO.output_gen's issues #155

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Resolve IO.output_gen's issues #155

wants to merge 10 commits into from

Conversation

weilycoder
Copy link
Contributor

@weilycoder weilycoder commented Nov 29, 2024 •
edited
Loading

@weilycoder weilycoder mentioned this pull request Nov 29, 2024
Open
@weilycoder

This comment was marked as outdated.

Sign in to view
@weilycoder
Copy link
Contributor Author

重写了 output_gen，直接使用 Popen.communicate 交互；同时，顺便解决了 #156 的问题。

@weilycoder weilycoder changed the title Resolve end-of-line sequence issues Resolve IO.output_gen's issues Dec 4, 2024
@weilycoder weilycoder mentioned this pull request Dec 4, 2024
Open
@weilycoder
Copy link
Contributor Author

本地对生成的安装包进行了测试（Linux），可以正常使用 pip 安装并解决上述问题。

@weilycoder
Copy link
Contributor Author

weilycoder commented Dec 9, 2024 •
edited
Loading

@Mr-Python-in-China 将 input_file 的赋值删除可能引发报错，例如若将输入文件以字符串形式传入，但打开失败（目录不存在），注意此时 input_file 并未赋值，因此垃圾回收时会报错。

我调了好久才定位。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weilycoder @Mr-Python-in-China