Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved response to unauthorized user / Session token set with unauthorized user. #99

Closed
russmac opened this issue Sep 7, 2016 · 3 comments

Comments

@russmac
Copy link
Contributor

russmac commented Sep 7, 2016

I was logging in my existing Gmail account automatically with existing cookie that was correctly not authorized for access due to domain.

However, The login appeared to succeed and the resource listing page displayed (with no data). Indicating login authorized , It would be good to redirect to loggedout or a 401.

The confidant_session token was also set despite logs showing failed authorization. It of course appears to be correctly unauthorized.

When I click create service I got this error. Which had me thinking my AWS infra was misnamed or my dynamodb tables had not been nuked before recreation during provisioning. It is due to the correct 403 on all v1/ resources.

{{ grantUpdateError }}

{{ saveError }}

The following credential pair keys conflict in the listed credentials:

Please ensure credential pair keys are unique, then try again.
Service ID {{ service.id || "Not set." }} {{ service.id || "Not set." }}
AWS Account {{ service.account }} No account scoping No account scoping
Service Enabled {{ service.enabled }} 
@russmac russmac changed the title Improved response to unauthorized user. Improved response to unauthorized user / Session token set with unauthorized user. Sep 7, 2016
@ryan-lane
Copy link
Contributor

Yep. We have an open issue for this: #64

Ideally this would redirect to another page that gave a proper error message, rather than logged out, so that people get an indication that they've made a mistake.

@russmac
Copy link
Contributor Author

russmac commented Sep 7, 2016

Apologies for the dupe.

@russmac russmac closed this as completed Sep 7, 2016
@ryan-lane
Copy link
Contributor

No worries! I'll think of a reasonable way of solving this :)

On Sep 6, 2016 10:21 PM, "Russell Maclean" [email protected] wrote:

Apologies for the dupe.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#99 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABd5MsndSezBtp5JAOjHsIZd3NkEQmP3ks5qnknSgaJpZM4J2ctE
.

tstallings pushed a commit that referenced this issue Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants