From 0546fc5e83be43e316727b50b39140d2eb0c44f6 Mon Sep 17 00:00:00 2001 From: Lars Vogel Date: Tue, 22 Jun 2021 09:43:51 +0200 Subject: [PATCH] Bug 574376 - [dogfooding][cleanup] Use new StringBuffer -> StringBuilder cleanup Runs the new StringBuffer-> StringBuilder This help to determine that it works correctly for clients we should run it also on our own code base. This help to ensure that the cleanup works fine and helps us to cleanup our own code base. From the commit message of the cleanup: - create a cleanup to replace usage of StringBuffer with StringBuilder. The two are equivalent, but StringBuffer is thread-safe and synchronized which makes it slower than StringBuilder which was introduced in Java 1.5. This uses the local variable change only. Change-Id: Iec3f968dd879c63b3e108c31a5a6e8178b8617bf Signed-off-by: Lars Vogel Reviewed-on: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/182327 Tested-by: JDT Bot Reviewed-by: Jeff Johnston --- .../jdt/internal/corext/dom/ASTNodes.java | 4 +- .../corext/fix/SwitchExpressionsFixCore.java | 4 +- .../junit/model/TestRunSessionSerializer.java | 4 +- .../junit/runner/RemoteTestRunner.java | 2 +- .../wizards/NewTestCaseWizardPageOne.java | 2 +- .../text/tests/PartitionTokenScannerTest.java | 8 +- .../jdt/text/tests/PluginsNotLoadedTest.java | 2 +- .../contentassist/AbstractCompletionTest.java | 8 +- .../contentassist/CodeCompletionTest.java | 134 +++++++++--------- .../contentassist/CodeCompletionTest1d8.java | 60 ++++---- .../org/eclipse/jsp/AbstractJspParser.java | 2 +- .../jdt/ui/examples/ASTRewriteSnippet.java | 4 +- .../leaks/TextViewerUndoManagerLeakTest.java | 2 +- .../ui/tests/leaks/UndoManagerLeakTest.java | 2 +- .../eclipse/jdt/testplugin/NullTestUtils.java | 14 +- .../eclipse/jdt/testplugin/StringAsserts.java | 8 +- .../internal/ui/dialogs/TypeInfoViewer.java | 2 +- .../ui/text/java/hover/JavadocHover.java | 8 +- 18 files changed, 135 insertions(+), 135 deletions(-) diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/ASTNodes.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/ASTNodes.java index fcac56e8c82..42efb3ff691 100644 --- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/ASTNodes.java +++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/dom/ASTNodes.java @@ -1085,7 +1085,7 @@ public static ChildListPropertyDescriptor getBodyDeclarationsProperty(ASTNode no * @since 3.10 */ public static String getTypeName(Type type) { - final StringBuffer buffer= new StringBuffer(); + final StringBuilder buffer= new StringBuilder(); ASTVisitor visitor= new ASTVisitor() { @Override public boolean visit(PrimitiveType node) { @@ -1132,7 +1132,7 @@ public void endVisit(ArrayType node) { * @since 3.10 */ public static String getQualifiedTypeName(Type type) { - final StringBuffer buffer= new StringBuffer(); + final StringBuilder buffer= new StringBuilder(); ASTVisitor visitor= new ASTVisitor() { @Override public boolean visit(SimpleType node) { diff --git a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/fix/SwitchExpressionsFixCore.java b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/fix/SwitchExpressionsFixCore.java index c840a752a55..b3848236eb4 100644 --- a/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/fix/SwitchExpressionsFixCore.java +++ b/org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/fix/SwitchExpressionsFixCore.java @@ -297,7 +297,7 @@ public void rewriteAST(CompilationUnitRewrite cuRewrite, LinkedProposalModelCore Expression rhs= oldAssignment.getRightHandSide(); // Ugly hack to tack on trailing comments IBuffer buffer= cuRewrite.getCu().getBuffer(); - StringBuffer b= new StringBuffer(); + StringBuilder b= new StringBuilder(); b.append(buffer.getText(rhs.getStartPosition(), rhs.getLength()) + ";"); //$NON-NLS-1$ List trailingComments= ASTNodes.getTrailingComments(oldExpStatement); for (Comment comment : trailingComments) { @@ -317,7 +317,7 @@ public void rewriteAST(CompilationUnitRewrite cuRewrite, LinkedProposalModelCore Assignment oldAssignment= (Assignment)oldExpStatement.getExpression(); Expression rhs= oldAssignment.getRightHandSide(); IBuffer buffer= cuRewrite.getCu().getBuffer(); - StringBuffer b= new StringBuffer(); + StringBuilder b= new StringBuilder(); List leadingComments= ASTNodes.getLeadingComments(oldExpStatement); for (Comment comment : leadingComments) { b.append(buffer.getText(comment.getStartPosition(), comment.getLength()) + "\n"); //$NON-NLS-1$ diff --git a/org.eclipse.jdt.junit.core/src/org/eclipse/jdt/internal/junit/model/TestRunSessionSerializer.java b/org.eclipse.jdt.junit.core/src/org/eclipse/jdt/internal/junit/model/TestRunSessionSerializer.java index 94f3b01db2f..0d40603605b 100644 --- a/org.eclipse.jdt.junit.core/src/org/eclipse/jdt/internal/junit/model/TestRunSessionSerializer.java +++ b/org.eclipse.jdt.junit.core/src/org/eclipse/jdt/internal/junit/model/TestRunSessionSerializer.java @@ -235,12 +235,12 @@ private void addCharacters(String string) throws SAXException { * @since 3.6 */ private static String escapeNonUnicodeChars(String string) { - StringBuffer buf= null; + StringBuilder buf= null; for (int i= 0; i < string.length(); i++) { char ch= string.charAt(i); if (ch != 9 && ch != 10 && ch != 13 && ch < 32) { if (buf == null) { - buf= new StringBuffer(string.substring(0, i)); + buf= new StringBuilder(string.substring(0, i)); } buf.append("\\u"); //$NON-NLS-1$ String hex= Integer.toHexString(ch); diff --git a/org.eclipse.jdt.junit.runtime/src/org/eclipse/jdt/internal/junit/runner/RemoteTestRunner.java b/org.eclipse.jdt.junit.runtime/src/org/eclipse/jdt/internal/junit/runner/RemoteTestRunner.java index c3e01b84584..fbc674f2610 100644 --- a/org.eclipse.jdt.junit.runtime/src/org/eclipse/jdt/internal/junit/runner/RemoteTestRunner.java +++ b/org.eclipse.jdt.junit.runtime/src/org/eclipse/jdt/internal/junit/runner/RemoteTestRunner.java @@ -586,7 +586,7 @@ public void visitTreeEntry(ITestIdentifier identifier, boolean hasChildren, int public static String escapeText(String s) { if ((s.indexOf(',') < 0) && (s.indexOf('\\') < 0) && (s.indexOf('\r') < 0) && (s.indexOf('\n') < 0)) return s; - StringBuffer sb= new StringBuffer(s.length()+10); + StringBuilder sb= new StringBuilder(s.length()+10); for (int i= 0; i < s.length(); i++) { char c= s.charAt(i); switch (c) { diff --git a/org.eclipse.jdt.junit/src/org/eclipse/jdt/junit/wizards/NewTestCaseWizardPageOne.java b/org.eclipse.jdt.junit/src/org/eclipse/jdt/junit/wizards/NewTestCaseWizardPageOne.java index e60f8461058..8c14bd55902 100644 --- a/org.eclipse.jdt.junit/src/org/eclipse/jdt/junit/wizards/NewTestCaseWizardPageOne.java +++ b/org.eclipse.jdt.junit/src/org/eclipse/jdt/junit/wizards/NewTestCaseWizardPageOne.java @@ -1174,7 +1174,7 @@ private void appendTestMethodBody(StringBuffer buffer, ICompilationUnit targetCu private void appendParameterNamesToMethodName(StringBuffer buffer, String[] parameters) { for (String parameter : parameters) { - final StringBuffer buf= new StringBuffer(Signature.getSimpleName(Signature.toString(Signature.getElementType(parameter)))); + final StringBuilder buf= new StringBuilder(Signature.getSimpleName(Signature.toString(Signature.getElementType(parameter)))); final char character= buf.charAt(0); if (buf.length() > 0 && !Character.isUpperCase(character)) buf.setCharAt(0, Character.toUpperCase(character)); diff --git a/org.eclipse.jdt.text.tests/src/org/eclipse/jdt/text/tests/PartitionTokenScannerTest.java b/org.eclipse.jdt.text.tests/src/org/eclipse/jdt/text/tests/PartitionTokenScannerTest.java index f39dd687d12..0c9d79ff5aa 100644 --- a/org.eclipse.jdt.text.tests/src/org/eclipse/jdt/text/tests/PartitionTokenScannerTest.java +++ b/org.eclipse.jdt.text.tests/src/org/eclipse/jdt/text/tests/PartitionTokenScannerTest.java @@ -72,7 +72,7 @@ private IDocument getDocument(String name, String lineDelimiter) { public static IDocument getRandomDocument(int size) { final char[] characters= {'/', '*', '\'', '"', '\r', '\n', '\\'}; - final StringBuffer buffer= new StringBuffer(); + final StringBuilder buffer= new StringBuilder(); for (int i= 0; i < size; i++) { final int randomIndex= (int) (Math.random() * characters.length); @@ -165,7 +165,7 @@ private long getTime(IPartitionTokenScanner scanner, IDocument document, int cou private void testConformance(final IDocument document) { - final StringBuffer message= new StringBuffer(); + final StringBuilder message= new StringBuilder(); fReference.setRange(document, 0, document.getLength()); fTestee.setRange(document, 0, document.getLength()); @@ -215,7 +215,7 @@ private void assertTokenEquals(IToken expected, IToken actual) { } private static String extractString(IDocument document, int offset) { - final StringBuffer buffer= new StringBuffer(); + final StringBuilder buffer= new StringBuilder(); try { IRegion region= document.getLineInformationOfOffset(offset); @@ -246,7 +246,7 @@ private static String extractString(IDocument document, int offset) { * @return the escaped string */ public static String escape(String string) { - final StringBuffer buffer= new StringBuffer(); + final StringBuilder buffer= new StringBuilder(); final int length= string.length(); for (int i= 0; i < length; i++) { diff --git a/org.eclipse.jdt.text.tests/src/org/eclipse/jdt/text/tests/PluginsNotLoadedTest.java b/org.eclipse.jdt.text.tests/src/org/eclipse/jdt/text/tests/PluginsNotLoadedTest.java index 5c6b534c5ff..d013a189b85 100644 --- a/org.eclipse.jdt.text.tests/src/org/eclipse/jdt/text/tests/PluginsNotLoadedTest.java +++ b/org.eclipse.jdt.text.tests/src/org/eclipse/jdt/text/tests/PluginsNotLoadedTest.java @@ -258,7 +258,7 @@ public void printNotLoaded() { @Test public void pluginsNotLoaded() { - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); for (String element : NOT_LOADED_BUNDLES) { Bundle bundle= Platform.getBundle(element); if (element.contains("org.junit")) diff --git a/org.eclipse.jdt.text.tests/src/org/eclipse/jdt/text/tests/contentassist/AbstractCompletionTest.java b/org.eclipse.jdt.text.tests/src/org/eclipse/jdt/text/tests/contentassist/AbstractCompletionTest.java index 3df0fa4a18a..8b0e5182ba0 100644 --- a/org.eclipse.jdt.text.tests/src/org/eclipse/jdt/text/tests/contentassist/AbstractCompletionTest.java +++ b/org.eclipse.jdt.text.tests/src/org/eclipse/jdt/text/tests/contentassist/AbstractCompletionTest.java @@ -440,7 +440,7 @@ private IRegion assembleMethodBodyTestCUExtractSelection(StringBuffer buffer, St " }\n" + fMembers + "}\n"; - StringBuffer lineBuffer= new StringBuffer(javadocLine); + StringBuilder lineBuffer= new StringBuilder(javadocLine); int firstPipe= lineBuffer.indexOf(CARET); int secondPipe; if (firstPipe == -1) { @@ -469,7 +469,7 @@ private IRegion assembleClassBodyTestCUExtractSelection(StringBuffer buffer, Str "\n" + fMembers + "}\n"; - StringBuffer lineBuffer= new StringBuffer(javadocLine); + StringBuilder lineBuffer= new StringBuilder(javadocLine); int firstPipe= lineBuffer.indexOf(CARET); int secondPipe; if (firstPipe == -1) { @@ -498,7 +498,7 @@ private IRegion assembleClassJavadocTestCUExtractSelection(StringBuffer buffer, "\n" + fMembers + "}\n"; - StringBuffer lineBuffer= new StringBuffer(javadocLine); + StringBuilder lineBuffer= new StringBuilder(javadocLine); int firstPipe= lineBuffer.indexOf(CARET); int secondPipe; if (firstPipe == -1) { @@ -525,7 +525,7 @@ private IRegion assembleMethodJavadocTestCUExtractSelection(StringBuffer buffer, " */\n" + fMembers + "}\n"; - StringBuffer lineBuffer= new StringBuffer(javadocLine); + StringBuilder lineBuffer= new StringBuilder(javadocLine); int firstPipe= lineBuffer.indexOf(CARET); int secondPipe; if (firstPipe == -1) { diff --git a/org.eclipse.jdt.text.tests/src/org/eclipse/jdt/text/tests/contentassist/CodeCompletionTest.java b/org.eclipse.jdt.text.tests/src/org/eclipse/jdt/text/tests/contentassist/CodeCompletionTest.java index 1bbaab14f0c..d47ff634672 100644 --- a/org.eclipse.jdt.text.tests/src/org/eclipse/jdt/text/tests/contentassist/CodeCompletionTest.java +++ b/org.eclipse.jdt.text.tests/src/org/eclipse/jdt/text/tests/contentassist/CodeCompletionTest.java @@ -215,7 +215,7 @@ public void testAnonymousTypeCompletion1() throws Exception { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("public class A {\n"); buf.append(" public void foo() {\n"); @@ -243,7 +243,7 @@ public void testAnonymousTypeCompletion1() throws Exception { proposals[0].apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n" + "public class A {\n" + " public void foo() {\n" + @@ -265,7 +265,7 @@ public void testAnonymousTypeCompletion2() throws Exception { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("public class A {\n"); buf.append(" public void foo() {\n"); @@ -293,7 +293,7 @@ public void testAnonymousTypeCompletion2() throws Exception { proposals[0].apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n" + "public class A {\n" + " public void foo() {\n" + @@ -315,7 +315,7 @@ public void testAnonymousTypeCompletion3() throws Exception { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("public class A {\n"); buf.append(" interface Inner {\n"); @@ -346,7 +346,7 @@ public void testAnonymousTypeCompletion3() throws Exception { proposals[0].apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("public class A {\n"); buf.append(" interface Inner {\n"); @@ -370,7 +370,7 @@ public void testAnonymousTypeCompletion4() throws Exception { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("public class A {\n"); buf.append(" public void foo() {\n"); @@ -401,7 +401,7 @@ public void testAnonymousTypeCompletion4() throws Exception { proposals[0].apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("public class A {\n"); buf.append(" public void foo() {\n"); @@ -426,7 +426,7 @@ public void testAnonymousTypeCompletion5() throws Exception { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("public class A {\n"); buf.append(" abstract class Local {\n"); @@ -458,7 +458,7 @@ public void testAnonymousTypeCompletion5() throws Exception { proposals[0].apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("public class A {\n"); buf.append(" abstract class Local {\n"); @@ -483,7 +483,7 @@ public void testAnonymousTypeCompletion6() throws Exception { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("import java.io.Serializable;\n"); buf.append("//BUG\n"); @@ -513,7 +513,7 @@ public void testAnonymousTypeCompletion6() throws Exception { proposals[0].apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n" + "import java.io.Serializable;\n"+ "//BUG\n"+ @@ -765,7 +765,7 @@ public void testAnonymousTypeCompletionBug280801() throws Exception { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("public class Try {\n"); buf.append(" Object m() {\n"); @@ -793,7 +793,7 @@ public void testAnonymousTypeCompletionBug280801() throws Exception { proposals[0].apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("public class Try {\n"); buf.append(" Object m() {\n"); @@ -814,7 +814,7 @@ public void testAnonymousTypeCompletionBug324391() throws Exception { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("public class Try {\n"); buf.append(" Object m() {\n"); @@ -842,7 +842,7 @@ public void testAnonymousTypeCompletionBug324391() throws Exception { proposals[0].apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("public class Try {\n"); buf.append(" Object m() {\n"); @@ -863,7 +863,7 @@ public void testAnonymousTypeCompletionBug326377() throws Exception { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("public class Try {\n"); buf.append(" Object m() {\n"); @@ -891,7 +891,7 @@ public void testAnonymousTypeCompletionBug326377() throws Exception { proposals[0].apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("public class Try {\n"); buf.append(" Object m() {\n"); @@ -918,7 +918,7 @@ public void testAnonymousTypeCompletionBug526615() throws Exception { "public abstract class B {}", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("/**\n"); buf.append(" * Lore ipsum dolor sit amet, consectetur adipisici elit,\n"); @@ -950,7 +950,7 @@ public void testAnonymousTypeCompletionBug526615() throws Exception { proposals[0].apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("/**\n"); buf.append(" * Lore ipsum dolor sit amet, consectetur adipisici elit,\n"); @@ -970,7 +970,7 @@ public void testConstructorCompletion() throws Exception { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("import java.io.BufferedWriter;\n"); @@ -1006,7 +1006,7 @@ public void testConstructorCompletion() throws Exception { IDocument doc= JavaUI.getDocumentProvider().getDocument(part.getEditorInput()); proposal.apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("import java.io.BufferedWriter;\n"); @@ -1104,7 +1104,7 @@ public void testGetterCompletion1() throws Exception { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("import java.io.BufferedWriter;\n"); @@ -1140,7 +1140,7 @@ public void testGetterCompletion1() throws Exception { IDocument doc= JavaUI.getDocumentProvider().getDocument(part.getEditorInput()); proposal.apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("import java.io.BufferedWriter;\n"); @@ -1165,7 +1165,7 @@ public void testMethodCompletion() throws Exception { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("import java.io.BufferedWriter;\n"); @@ -1201,7 +1201,7 @@ public void testMethodCompletion() throws Exception { IDocument doc= JavaUI.getDocumentProvider().getDocument(part.getEditorInput()); proposal.apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("import java.io.BufferedWriter;\n"); @@ -1427,7 +1427,7 @@ public void testOverrideCompletion1() throws Exception { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("import java.io.Writer;\n"); @@ -1464,7 +1464,7 @@ public void testOverrideCompletion1() throws Exception { IDocument doc= new Document(contents); toStringProposal.apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("import java.io.Writer;\n"); @@ -1489,7 +1489,7 @@ public void testOverrideCompletion2() throws Exception { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("import java.io.Writer;\n"); @@ -1526,7 +1526,7 @@ public void testOverrideCompletion2() throws Exception { IDocument doc= new Document(contents); closeProposal.apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("import java.io.IOException;\n"); @@ -1552,7 +1552,7 @@ public void testOverrideCompletion3() throws Exception { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("import java.io.BufferedWriter;\n"); @@ -1589,7 +1589,7 @@ public void testOverrideCompletion3() throws Exception { IDocument doc= new Document(contents); closeProposal.apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("import java.io.BufferedWriter;\n"); @@ -1615,7 +1615,7 @@ public void testOverrideCompletion4() throws Exception { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("public class A {\n"); @@ -1624,7 +1624,7 @@ public void testOverrideCompletion4() throws Exception { buf.append("}\n"); pack1.createCompilationUnit("A.java", buf.toString(), false, null); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("public interface Inter {\n"); @@ -1632,7 +1632,7 @@ public void testOverrideCompletion4() throws Exception { buf.append("}\n"); pack1.createCompilationUnit("Inter.java", buf.toString(), false, null); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("public class B extends A implements Inter {\n"); @@ -1665,7 +1665,7 @@ public void testOverrideCompletion4() throws Exception { IDocument doc= new Document(contents); closeProposal.apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("public class B extends A implements Inter {\n"); @@ -1688,7 +1688,7 @@ public void testOverrideCompletion5() throws Exception { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("public class A {\n"); @@ -1725,7 +1725,7 @@ public void testOverrideCompletion5() throws Exception { IDocument doc= new Document(contents); toStringProposal.apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("public class A {\n"); @@ -1749,7 +1749,7 @@ public void testOverrideCompletion6_bug157069() throws Exception { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("public class A {\n"); @@ -1759,7 +1759,7 @@ public void testOverrideCompletion6_bug157069() throws Exception { buf.append("}\n"); pack1.createCompilationUnit("A.java", buf.toString(), false, null); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("public class B extends A {\n"); @@ -1792,7 +1792,7 @@ public void testOverrideCompletion6_bug157069() throws Exception { IDocument doc= new Document(contents); closeProposal.apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("public class B extends A {\n"); @@ -1814,7 +1814,7 @@ public void testOverrideCompletion7_bug355926() throws Exception { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("interface Z {}\n"); @@ -1853,7 +1853,7 @@ public void testOverrideCompletion7_bug355926() throws Exception { IDocument doc= new Document(contents); toStringProposal.apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("interface Z {}\n"); @@ -1881,7 +1881,7 @@ public void testOverrideCompletion8_bug355926() throws Exception { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("interface Z {}\n"); @@ -1920,7 +1920,7 @@ public void testOverrideCompletion8_bug355926() throws Exception { IDocument doc= new Document(contents); toStringProposal.apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("interface Z {}\n"); @@ -1948,7 +1948,7 @@ public void testOverrideCompletion9_bug355926() throws Exception { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("import java.util.List;\n"); @@ -1989,7 +1989,7 @@ public void testOverrideCompletion9_bug355926() throws Exception { IDocument doc= new Document(contents); toStringProposal.apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("import java.util.List;\n"); @@ -2019,7 +2019,7 @@ public void testOverrideCompletion10_bug377184() throws Exception { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("class Super {\n"); buf.append(" void foo(T t) {\n"); @@ -2052,7 +2052,7 @@ public void testOverrideCompletion10_bug377184() throws Exception { IDocument doc= new Document(contents); toStringProposal.apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("class Super {\n"); buf.append(" void foo(T t) {\n"); @@ -2077,7 +2077,7 @@ public void testOverrideCompletionArrayOfTypeVariable() throws Exception { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("class Super {\n"); buf.append(" public void foo(T[] t) {\n"); @@ -2110,7 +2110,7 @@ public void testOverrideCompletionArrayOfTypeVariable() throws Exception { IDocument doc= new Document(contents); toStringProposal.apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("class Super {\n"); buf.append(" public void foo(T[] t) {\n"); @@ -2134,7 +2134,7 @@ public void testSetterCompletion1() throws Exception { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("import java.io.BufferedWriter;\n"); @@ -2170,7 +2170,7 @@ public void testSetterCompletion1() throws Exception { IDocument doc= JavaUI.getDocumentProvider().getDocument(part.getEditorInput()); proposal.apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("import java.io.BufferedWriter;\n"); @@ -2198,7 +2198,7 @@ public void testStaticImports1() throws Exception { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("public class A {\n"); @@ -2207,7 +2207,7 @@ public void testStaticImports1() throws Exception { buf.append("}\n"); pack1.createCompilationUnit("A.java", buf.toString(), false, null); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("public class B {\n"); @@ -2245,7 +2245,7 @@ public void testStaticImports1() throws Exception { IDocument doc= JavaUI.getDocumentProvider().getDocument(part.getEditorInput()); proposal.apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("import static test1.A.foo;\n"); @@ -2271,7 +2271,7 @@ public void testStaticImports2() throws Exception { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("public class A {\n"); @@ -2281,7 +2281,7 @@ public void testStaticImports2() throws Exception { pack1.createCompilationUnit("A.java", buf.toString(), false, null); IPackageFragment pack2= sourceFolder.createPackageFragment("test2", false, null); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test2;\n"); buf.append("\n"); buf.append("public class B {\n"); @@ -2323,7 +2323,7 @@ public void testStaticImports2() throws Exception { IDocument doc= JavaUI.getDocumentProvider().getDocument(part.getEditorInput()); proposal.apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test2;\n"); buf.append("\n"); buf.append("import test1.A;\n"); @@ -2351,7 +2351,7 @@ public void testImport() throws Exception { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("import java.util.ArrayL; // here\n"); buf.append("public class A {\n"); @@ -2376,7 +2376,7 @@ public void testImport() throws Exception { IDocument doc= JavaUI.getDocumentProvider().getDocument(part.getEditorInput()); proposals.get(0).apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("import java.util.ArrayList; // here\n"); buf.append("public class A {\n"); @@ -2392,7 +2392,7 @@ public void testImportReplacingSelection() throws Exception { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("import java.util.ArrayLWrong;\n"); buf.append("public class A {\n"); @@ -2417,7 +2417,7 @@ public void testImportReplacingSelection() throws Exception { IDocument doc= JavaUI.getDocumentProvider().getDocument(part.getEditorInput()); proposals[0].apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("import java.util.ArrayList;\n"); buf.append("public class A {\n"); @@ -2435,7 +2435,7 @@ public void testImportReplacing() throws Exception { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("import java.util.ArrayLWrong;\n"); buf.append("public class A {\n"); @@ -2459,7 +2459,7 @@ public void testImportReplacing() throws Exception { IDocument doc= JavaUI.getDocumentProvider().getDocument(part.getEditorInput()); proposals[0].apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("import java.util.ArrayList;\n"); buf.append("public class A {\n"); @@ -2472,7 +2472,7 @@ public void testConstructorCompletion_Bug336451() throws Exception { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("public class EclipseTest {\n"); buf.append(" private static interface InvokerIF{\n"); buf.append(" public T invoke(T arg) throws RuntimeException, IndexOutOfBoundsException;\n"); @@ -2522,7 +2522,7 @@ public void testConstructorCompletion_Bug336451() throws Exception { proposals[0].apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("public class EclipseTest {\n"); buf.append(" private static interface InvokerIF{\n"); buf.append(" public T invoke(T arg) throws RuntimeException, IndexOutOfBoundsException;\n"); diff --git a/org.eclipse.jdt.text.tests/src/org/eclipse/jdt/text/tests/contentassist/CodeCompletionTest1d8.java b/org.eclipse.jdt.text.tests/src/org/eclipse/jdt/text/tests/contentassist/CodeCompletionTest1d8.java index 75d7e5c5c67..e07015f5031 100644 --- a/org.eclipse.jdt.text.tests/src/org/eclipse/jdt/text/tests/contentassist/CodeCompletionTest1d8.java +++ b/org.eclipse.jdt.text.tests/src/org/eclipse/jdt/text/tests/contentassist/CodeCompletionTest1d8.java @@ -196,7 +196,7 @@ public void testBug425183_comment8() throws CoreException { public void testOverride1() throws CoreException { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("public class Main {\n"); buf.append(" private static class Cls implements Interface {\n"); @@ -223,7 +223,7 @@ public void testOverride1() throws CoreException { IDocument doc= JavaUI.getDocumentProvider().getDocument(part.getEditorInput()); proposals[0].apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("public class Main {\n"); buf.append(" private static class Cls implements Interface {\n"); @@ -249,7 +249,7 @@ public void testOverride1() throws CoreException { public void testOverride2() throws CoreException { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("public class Main {\n"); buf.append(" private static interface Bar extends Foo {\n"); @@ -276,7 +276,7 @@ public void testOverride2() throws CoreException { IDocument doc= JavaUI.getDocumentProvider().getDocument(part.getEditorInput()); proposals[0].apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("public class Main {\n"); buf.append(" private static interface Bar extends Foo {\n"); @@ -302,7 +302,7 @@ public void testOverride2() throws CoreException { public void testOverride3() throws CoreException { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("public interface I {\n"); buf.append(" default int getSize(String name) {\n"); @@ -327,7 +327,7 @@ public void testOverride3() throws CoreException { IDocument doc= JavaUI.getDocumentProvider().getDocument(part.getEditorInput()); proposals[0].apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("public interface I {\n"); buf.append(" default int getSize(String name) {\n"); @@ -351,7 +351,7 @@ public void testOverride3() throws CoreException { public void testOverride0() throws CoreException { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("import java.util.Collection;\n"); buf.append("abstract class X implements Collection {\n"); @@ -371,7 +371,7 @@ public void testOverride0() throws CoreException { IDocument doc= JavaUI.getDocumentProvider().getDocument(part.getEditorInput()); proposals[0].apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("import java.util.Collection;\n"); buf.append("import java.util.stream.Stream;\n"); @@ -392,7 +392,7 @@ public void testOverride0() throws CoreException { public void testOverride5() throws CoreException { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("public interface I1 {\n"); @@ -413,7 +413,7 @@ public void testOverride5() throws CoreException { IDocument doc= JavaUI.getDocumentProvider().getDocument(part.getEditorInput()); proposals[0].apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("public interface I1 {\n"); @@ -430,7 +430,7 @@ public void testOverride5() throws CoreException { public void testOverride6() throws CoreException { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("public interface I2 {\n"); @@ -451,7 +451,7 @@ public void testOverride6() throws CoreException { IDocument doc= JavaUI.getDocumentProvider().getDocument(part.getEditorInput()); proposals[0].apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("public interface I2 {\n"); @@ -468,7 +468,7 @@ public void testOverride6() throws CoreException { public void testOverride7() throws CoreException { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("public interface I3 {\n"); @@ -489,7 +489,7 @@ public void testOverride7() throws CoreException { IDocument doc= JavaUI.getDocumentProvider().getDocument(part.getEditorInput()); proposals[0].apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("public interface I3 {\n"); @@ -506,7 +506,7 @@ public void testOverride7() throws CoreException { public void testOverride8() throws CoreException { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("public interface I4 {\n"); @@ -527,7 +527,7 @@ public void testOverride8() throws CoreException { IDocument doc= JavaUI.getDocumentProvider().getDocument(part.getEditorInput()); proposals[2].apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("public interface I4 {\n"); @@ -543,7 +543,7 @@ public void testOverride8() throws CoreException { public void testOverride9() throws CoreException { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("public interface I5 {\n"); @@ -564,7 +564,7 @@ public void testOverride9() throws CoreException { IDocument doc= JavaUI.getDocumentProvider().getDocument(part.getEditorInput()); proposals[1].apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("public interface I5 {\n"); @@ -580,7 +580,7 @@ public void testOverride9() throws CoreException { public void testOverride10() throws CoreException { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("public interface I6 extends A {\n"); @@ -605,7 +605,7 @@ public void testOverride10() throws CoreException { IDocument doc= JavaUI.getDocumentProvider().getDocument(part.getEditorInput()); proposals[0].apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("public interface I6 extends A {\n"); @@ -629,7 +629,7 @@ public void testOverride10() throws CoreException { public void testOverride11() throws CoreException { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("pp", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package pp;\n"); buf.append("\n"); buf.append("public class CC implements I2 {\n"); @@ -654,7 +654,7 @@ public void testOverride11() throws CoreException { IDocument doc= JavaUI.getDocumentProvider().getDocument(part.getEditorInput()); proposals[0].apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package pp;\n"); buf.append("\n"); buf.append("public class CC implements I2 {\n"); @@ -678,7 +678,7 @@ public void testOverride11() throws CoreException { public void testOverride12() throws CoreException { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("pp", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package pp;\n"); buf.append("\n"); buf.append("public class CC extends S1 {\n"); @@ -703,7 +703,7 @@ public void testOverride12() throws CoreException { IDocument doc= JavaUI.getDocumentProvider().getDocument(part.getEditorInput()); proposals[0].apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package pp;\n"); buf.append("\n"); buf.append("public class CC extends S1 {\n"); @@ -727,7 +727,7 @@ public void testOverride12() throws CoreException { public void testOverride13() throws CoreException { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("pp", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package pp;\n"); buf.append("\n"); buf.append("public class CC extends S1 {\n"); @@ -756,7 +756,7 @@ public void testOverride13() throws CoreException { IDocument doc= JavaUI.getDocumentProvider().getDocument(part.getEditorInput()); proposals[1].apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package pp;\n"); buf.append("\n"); buf.append("public class CC extends S1 {\n"); @@ -789,7 +789,7 @@ public void testBug528871() throws Exception { NullTestUtils.prepareNullTypeAnnotations(sourceFolder); try { IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("import annots.NonNull;\n"); @@ -827,7 +827,7 @@ public void testBug528871() throws Exception { proposals[0].apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("import annots.NonNull;\n"); @@ -862,7 +862,7 @@ public void testBug458321() throws Exception { IPackageFragmentRoot sourceFolder= JavaProjectHelper.addSourceContainer(fJProject1, "src"); IPackageFragment pack1= sourceFolder.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("import java.util.function.Consumer;\n"); @@ -902,7 +902,7 @@ public void testBug458321() throws Exception { IDocument doc= JavaUI.getDocumentProvider().getDocument(part.getEditorInput()); proposal.apply(doc); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("\n"); buf.append("import java.util.function.Consumer;\n"); diff --git a/org.eclipse.jdt.ui.examples.javafamily/src/org/eclipse/jsp/AbstractJspParser.java b/org.eclipse.jdt.ui.examples.javafamily/src/org/eclipse/jsp/AbstractJspParser.java index 2bc399a1afe..ccfee2d9028 100644 --- a/org.eclipse.jdt.ui.examples.javafamily/src/org/eclipse/jsp/AbstractJspParser.java +++ b/org.eclipse.jdt.ui.examples.javafamily/src/org/eclipse/jsp/AbstractJspParser.java @@ -136,7 +136,7 @@ private void parseAttributes(int pos, String s) { boolean hasValue= false; StringBuilder name= new StringBuilder(); - StringBuffer value= new StringBuffer(); + StringBuilder value= new StringBuilder(); String startTag= ""; //$NON-NLS-1$ int i= 0; int ix= 0; diff --git a/org.eclipse.jdt.ui.tests/examples/org/eclipse/jdt/ui/examples/ASTRewriteSnippet.java b/org.eclipse.jdt.ui.tests/examples/org/eclipse/jdt/ui/examples/ASTRewriteSnippet.java index 57c7b763b6b..1c889640e20 100644 --- a/org.eclipse.jdt.ui.tests/examples/org/eclipse/jdt/ui/examples/ASTRewriteSnippet.java +++ b/org.eclipse.jdt.ui.tests/examples/org/eclipse/jdt/ui/examples/ASTRewriteSnippet.java @@ -80,7 +80,7 @@ public void testASTRewriteExample() throws Exception { // create a test file IPackageFragmentRoot root= javaProject.getPackageFragmentRoot(project); IPackageFragment pack1= root.createPackageFragment("test1", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("public class E {\n"); buf.append(" public void foo(int i) {\n"); @@ -132,7 +132,7 @@ public void testASTRewriteExample() throws Exception { // test result String preview= cu.getSource(); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package test1;\n"); buf.append("public class E {\n"); buf.append(" public void foo(int i) {\n"); diff --git a/org.eclipse.jdt.ui.tests/leaks/org/eclipse/jdt/ui/tests/leaks/TextViewerUndoManagerLeakTest.java b/org.eclipse.jdt.ui.tests/leaks/org/eclipse/jdt/ui/tests/leaks/TextViewerUndoManagerLeakTest.java index 9ea3f918759..3cec638b856 100644 --- a/org.eclipse.jdt.ui.tests/leaks/org/eclipse/jdt/ui/tests/leaks/TextViewerUndoManagerLeakTest.java +++ b/org.eclipse.jdt.ui.tests/leaks/org/eclipse/jdt/ui/tests/leaks/TextViewerUndoManagerLeakTest.java @@ -214,7 +214,7 @@ private void internalTestRandomAccessAsCompound() { } private static String createRandomString(int length) { - final StringBuffer buffer= new StringBuffer(); + final StringBuilder buffer= new StringBuilder(); for (int i= 0; i < length; i++) buffer.append(getRandomCharacter()); diff --git a/org.eclipse.jdt.ui.tests/leaks/org/eclipse/jdt/ui/tests/leaks/UndoManagerLeakTest.java b/org.eclipse.jdt.ui.tests/leaks/org/eclipse/jdt/ui/tests/leaks/UndoManagerLeakTest.java index 67cca8935ca..b1f0dba6e13 100644 --- a/org.eclipse.jdt.ui.tests/leaks/org/eclipse/jdt/ui/tests/leaks/UndoManagerLeakTest.java +++ b/org.eclipse.jdt.ui.tests/leaks/org/eclipse/jdt/ui/tests/leaks/UndoManagerLeakTest.java @@ -195,7 +195,7 @@ private void internalTestRandomAccessAsCompound() { } private static String createRandomString(int length) { - final StringBuffer buffer= new StringBuffer(); + final StringBuilder buffer= new StringBuilder(); for (int i= 0; i < length; i++) buffer.append(getRandomCharacter()); diff --git a/org.eclipse.jdt.ui.tests/test plugin/org/eclipse/jdt/testplugin/NullTestUtils.java b/org.eclipse.jdt.ui.tests/test plugin/org/eclipse/jdt/testplugin/NullTestUtils.java index 8b0a1a7b783..7800bdc391d 100644 --- a/org.eclipse.jdt.ui.tests/test plugin/org/eclipse/jdt/testplugin/NullTestUtils.java +++ b/org.eclipse.jdt.ui.tests/test plugin/org/eclipse/jdt/testplugin/NullTestUtils.java @@ -34,21 +34,21 @@ public static void prepareNullDeclarationAnnotations(IPackageFragmentRoot source sourceFolder.getJavaProject().setOptions(options); IPackageFragment pack0= sourceFolder.createPackageFragment("annots", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package annots;\n"); buf.append("\n"); buf.append("@java.lang.annotation.Retention(java.lang.annotation.RetentionPolicy.CLASS)\n"); buf.append("public @interface NonNull {}\n"); pack0.createCompilationUnit("NonNull.java", buf.toString(), false, null); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package annots;\n"); buf.append("\n"); buf.append("@java.lang.annotation.Retention(java.lang.annotation.RetentionPolicy.CLASS)\n"); buf.append("public @interface Nullable {}\n"); pack0.createCompilationUnit("Nullable.java", buf.toString(), false, null); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package annots;\n"); buf.append("\n"); buf.append("import java.lang.annotation.*;\n"); @@ -69,7 +69,7 @@ public static void prepareNullTypeAnnotations(IPackageFragmentRoot sourceFolder) project.setOptions(options); IPackageFragment pack0= sourceFolder.createPackageFragment("annots", false, null); - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); buf.append("package annots;\n"); buf.append("\n"); buf.append("import java.lang.annotation.*;\n"); @@ -79,7 +79,7 @@ public static void prepareNullTypeAnnotations(IPackageFragmentRoot sourceFolder) buf.append("public @interface NonNull {}\n"); pack0.createCompilationUnit("NonNull.java", buf.toString(), false, null); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package annots;\n"); buf.append("\n"); buf.append("import java.lang.annotation.*;\n"); @@ -89,13 +89,13 @@ public static void prepareNullTypeAnnotations(IPackageFragmentRoot sourceFolder) buf.append("public @interface Nullable {}\n"); pack0.createCompilationUnit("Nullable.java", buf.toString(), false, null); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package annots;\n"); buf.append("\n"); buf.append("public enum DefaultLocation { PARAMETER, RETURN_TYPE, FIELD, TYPE_BOUND, TYPE_ARGUMENT, ARRAY_CONTENTS, TYPE_PARAMETER }\n"); pack0.createCompilationUnit("DefaultLocation.java", buf.toString(), false, null); - buf= new StringBuffer(); + buf= new StringBuilder(); buf.append("package annots;\n"); buf.append("\n"); buf.append("import java.lang.annotation.*;\n"); diff --git a/org.eclipse.jdt.ui.tests/test plugin/org/eclipse/jdt/testplugin/StringAsserts.java b/org.eclipse.jdt.ui.tests/test plugin/org/eclipse/jdt/testplugin/StringAsserts.java index 49daae0f41c..e1adc2e14de 100644 --- a/org.eclipse.jdt.ui.tests/test plugin/org/eclipse/jdt/testplugin/StringAsserts.java +++ b/org.eclipse.jdt.ui.tests/test plugin/org/eclipse/jdt/testplugin/StringAsserts.java @@ -125,7 +125,7 @@ public static void assertEqualStringsIgnoreOrder(String[] actuals, String[] expe assertEqualString(list1.get(0), list2.get(0)); } - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); for (int i= 0; i < n1; i++) { String s1= list1.get(i); if (s1 != null) { @@ -135,7 +135,7 @@ public static void assertEqualStringsIgnoreOrder(String[] actuals, String[] expe } String actual= buf.toString(); - buf= new StringBuffer(); + buf= new StringBuilder(); for (int i= 0; i < n2; i++) { String s2= list2.get(i); if (s2 != null) { @@ -168,7 +168,7 @@ public static void assertExpectedExistInProposals(String[] actuals, String[] exp assertEqualString(list1.get(0), list2.get(0)); } - StringBuffer buf= new StringBuffer(); + StringBuilder buf= new StringBuilder(); for (int i= 0; i < n1; i++) { String s1= list1.get(i); if (s1 != null) { @@ -178,7 +178,7 @@ public static void assertExpectedExistInProposals(String[] actuals, String[] exp } String actual= buf.toString(); - buf= new StringBuffer(); + buf= new StringBuilder(); for (int i= 0; i < n2; i++) { String s2= list2.get(i); if (s2 != null) { diff --git a/org.eclipse.jdt.ui/internal compatibility/org/eclipse/jdt/internal/ui/dialogs/TypeInfoViewer.java b/org.eclipse.jdt.ui/internal compatibility/org/eclipse/jdt/internal/ui/dialogs/TypeInfoViewer.java index b62df41715d..26ce58d43fa 100644 --- a/org.eclipse.jdt.ui/internal compatibility/org/eclipse/jdt/internal/ui/dialogs/TypeInfoViewer.java +++ b/org.eclipse.jdt.ui/internal compatibility/org/eclipse/jdt/internal/ui/dialogs/TypeInfoViewer.java @@ -751,7 +751,7 @@ private static class DashLine { private String fMessage; private int fMessageLength; public String getText(int width) { - StringBuffer dashes= new StringBuffer(); + StringBuilder dashes= new StringBuilder(); int chars= (((width - fMessageLength) / fSeparatorWidth) / 2) -2; for (int i= 0; i < chars; i++) { dashes.append(SEPARATOR); diff --git a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/hover/JavadocHover.java b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/hover/JavadocHover.java index adb64061a21..0b301a43dce 100644 --- a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/hover/JavadocHover.java +++ b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/hover/JavadocHover.java @@ -799,11 +799,11 @@ private static String getInfoText(IJavaElement element, ITypeRoot editorInputEle ASTNode node= haveSource ? getHoveredASTNode(editorInputElement, hoverRegion) : null; IBinding binding= getHoverBinding(element, node); - StringBuffer label; + StringBuilder label; if (binding != null) { - label= new StringBuffer(JavaElementLinks.getBindingLabel(binding, element, flags, haveSource)); + label= new StringBuilder(JavaElementLinks.getBindingLabel(binding, element, flags, haveSource)); } else { - label= new StringBuffer(JavaElementLinks.getElementLabel(element, flags)); + label= new StringBuilder(JavaElementLinks.getElementLabel(element, flags)); } if (element.getElementType() == IJavaElement.FIELD) { @@ -1102,7 +1102,7 @@ public static String getImageAndLabel(IJavaElement element, boolean allowImage, element= null; // no link } } - StringBuffer imageStyle= new StringBuffer("border:none; position: absolute; "); //$NON-NLS-1$ + StringBuilder imageStyle= new StringBuilder("border:none; position: absolute; "); //$NON-NLS-1$ imageStyle.append("width: ").append(imageWidth).append("px; "); //$NON-NLS-1$ //$NON-NLS-2$ imageStyle.append("height: ").append(imageHeight).append("px; "); //$NON-NLS-1$ //$NON-NLS-2$ imageStyle.append("left: ").append(- labelLeft - 1).append("px; "); //$NON-NLS-1$ //$NON-NLS-2$