Minor refactor

m7kvqbe1 · Oct 11, 2024 · 1e86cdf · 1e86cdf
1 parent 6fbdd4d
commit 1e86cdf
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 27 deletions.
diff --git a/dist/index.js b/dist/index.js
@@ -34479,6 +34479,14 @@ const parseCommaSeparatedInput = (input) => {
   return input.split(",").map((item) => item.trim());
 };
 
+const parseProjectUrl = (url) => {
+  const parts = url.split("/");
+  return {
+    orgName: parts[parts.length - 3],
+    projectUrl: url,
+  };
+};
+
 const validateIssue = (issue, TARGET_LABELS) => {
   if (!issue || !issue.node_id) {
     throw new Error("Invalid or missing issue object");
@@ -34488,15 +34496,7 @@ const validateIssue = (issue, TARGET_LABELS) => {
     throw new Error(`Issue #${issue.number} does not have a target label`);
   }
 
-  return true;
-};
-
-const parseProjectUrl = (url) => {
-  const parts = url.split("/");
-  return {
-    orgName: parts[parts.length - 3],
-    projectUrl: url,
-  };
+  return;
 };
 
 const fetchAllProjects = async (
@@ -34747,11 +34747,10 @@ const run = async () => {
     const octokit = github.getOctokit(token);
     const issue = github.context.payload.issue;
 
-    if (!validateIssue(issue, TARGET_LABELS)) {
-      return;
-    }
+    validateIssue(issue, TARGET_LABELS);
 
     const projectData = await getProjectData(octokit, projectUrl);
+
     await processIssueItem(
       octokit,
       projectData,

diff --git a/index.js b/index.js
@@ -5,6 +5,14 @@ const parseCommaSeparatedInput = (input) => {
   return input.split(",").map((item) => item.trim());
 };
 
+const parseProjectUrl = (url) => {
+  const parts = url.split("/");
+  return {
+    orgName: parts[parts.length - 3],
+    projectUrl: url,
+  };
+};
+
 const validateIssue = (issue, TARGET_LABELS) => {
   if (!issue || !issue.node_id) {
     throw new Error("Invalid or missing issue object");
@@ -14,15 +22,7 @@ const validateIssue = (issue, TARGET_LABELS) => {
     throw new Error(`Issue #${issue.number} does not have a target label`);
   }
 
-  return true;
-};
-
-const parseProjectUrl = (url) => {
-  const parts = url.split("/");
-  return {
-    orgName: parts[parts.length - 3],
-    projectUrl: url,
-  };
+  return;
 };
 
 const fetchAllProjects = async (
@@ -273,11 +273,10 @@ const run = async () => {
     const octokit = github.getOctokit(token);
     const issue = github.context.payload.issue;
 
-    if (!validateIssue(issue, TARGET_LABELS)) {
-      return;
-    }
+    validateIssue(issue, TARGET_LABELS);
 
     const projectData = await getProjectData(octokit, projectUrl);
+
     await processIssueItem(
       octokit,
       projectData,

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "github-action-move-issues",
-  "version": "1.0.7",
+  "version": "1.0.9",
   "description": "A GitHub Action to move issues between GitHub Projects V2 columns based on labels.",
   "main": "dist/index.js",
   "scripts": {