Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return to default column on label removal #7

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

m7kvqbe1
Copy link
Owner

@m7kvqbe1 m7kvqbe1 commented Oct 15, 2024

Closes #1

Return to default column on label removal.

@m7kvqbe1 m7kvqbe1 added the enhancement New feature or request label Oct 15, 2024
@m7kvqbe1 m7kvqbe1 self-assigned this Oct 15, 2024
@m7kvqbe1 m7kvqbe1 force-pushed the feat/default-column-label-remove branch from 78f8d6a to b1d73cb Compare October 15, 2024 07:17
@m7kvqbe1 m7kvqbe1 marked this pull request as ready for review October 15, 2024 07:17
@m7kvqbe1 m7kvqbe1 changed the title [WIP] Return to default column on label removal Return to default column on label removal Oct 15, 2024
@koppor
Copy link
Contributor

koppor commented Oct 15, 2024

Tested it on my project - result: https://github.com/JabRef/jabref/actions/runs/11342028984/job/31541550218

Error: Error moving issue: Issue #11707 does not have a target label

Internal note: I am testing with issue JabRef/jabref#11707 and label 📍 Assigned.

@koppor
Copy link
Contributor

koppor commented Oct 15, 2024

The error is very OK, because the issue does not belong to that project. With this error, #4 is implemented (quick and dirty). I would just need to ignore the failing step.

@m7kvqbe1 m7kvqbe1 force-pushed the feat/default-column-label-remove branch from 35b700b to a8f9766 Compare October 15, 2024 08:55
@m7kvqbe1
Copy link
Owner Author

I've added a change that ensures it only moves to the default-column if there are no target labels present.

@m7kvqbe1 m7kvqbe1 force-pushed the feat/default-column-label-remove branch from a8f9766 to 6e02626 Compare October 15, 2024 09:10
@m7kvqbe1 m7kvqbe1 force-pushed the feat/default-column-label-remove branch 2 times, most recently from e905232 to 6778639 Compare October 15, 2024 10:39
@m7kvqbe1 m7kvqbe1 force-pushed the feat/default-column-label-remove branch from 6778639 to 7bfcfe8 Compare October 15, 2024 10:45
@m7kvqbe1 m7kvqbe1 merged commit 915d0e7 into main Oct 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to column in the absence of a label
2 participants