Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline Block component with Angle Bracket syntax doesn't work #332

Open
musaffa opened this issue Apr 13, 2019 · 1 comment
Open

Multiline Block component with Angle Bracket syntax doesn't work #332

musaffa opened this issue Apr 13, 2019 · 1 comment

Comments

@musaffa
Copy link

musaffa commented Apr 13, 2019

Component invocation without Angle Bracket works:

= image-cropper [                                             
  source=this.previewSrc
  options=@options
] as |cropper|
  = cropper.on 'crop' action=(action 'crop')

Invocation with Angle Bracket syntax doesn't work:

% ImageCropper [
  @source=this.previewSrc
  @options=@options
] as |cropper|
  = cropper.on 'crop' action=(action 'crop')

But if I make it a single line, then it compiles without an issue:

% ImageCropper @source=this.previewSrc @options=@options as |cropper|
  = cropper.on 'crop' action=(action 'crop')
@musaffa musaffa changed the title Block component with Angle Bracket syntax doesn't work Multiline Block component with Angle Bracket syntax doesn't work Apr 13, 2019
@thec0keman
Copy link
Collaborator

Thanks for the report! It looks like block params are not currently set up to work for brackets and glimmer components.

This may take a bit more refactoring to support, but I'll start poking it at it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants