Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: allow all options to be passed through trix_editor_tag #20

Open
kylefox opened this issue May 31, 2016 · 6 comments
Open

Proposal: allow all options to be passed through trix_editor_tag #20

kylefox opened this issue May 31, 2016 · 6 comments

Comments

@kylefox
Copy link
Contributor

kylefox commented May 31, 2016

First off, thanks for the great library 👍 Dropping it in was a breeze!

I'd like to pass some extra attributes to the <trix-editor> tag. For example, required="true" and some data-* attributes.

I noticed that trix_editor_tag only passes specific options into the underlying call to content_tag.

What do you think about passing options directly into content_tag?

Cheers,
Kyle.

@rutger1140
Copy link

Plus one on this.

@ThunderGuppy
Copy link

Agreed. This would be awesome.

@maclover7
Copy link
Owner

@kylefox Thanks for opening up this issue! I'd definitely be open to having this be a thing. Please feel free to send over a pull request.

@paullimzw
Copy link

paullimzw commented Dec 20, 2016

it would be great if it could work with client_side_validations

@rvanlieshout
Copy link
Contributor

The editor itself only uses autofocus and placeholder. I've got a MR for this that might require some discussion about what needs to be passed to the hidden input and what needs to be passed to the trix-editor-tag

@kylefox
Copy link
Contributor Author

kylefox commented May 23, 2018

PR #67 (including specs + README) submitted!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants