Skip to content

Commit 88a2ca7

Browse files
committed
Revert "Printing last ouptput for undetected errors..."
This reverts commit 4cba57d.
1 parent 4cba57d commit 88a2ca7

File tree

3 files changed

+1
-23
lines changed

3 files changed

+1
-23
lines changed

xrun/Classes/XRXXcodeTask.m

+1-5
Original file line numberDiff line numberDiff line change
@@ -143,11 +143,7 @@ - ( BOOL )run: ( NSDictionary< NSString *, NSString * > * )variables
143143
ret = NO;
144144
}
145145

146-
if( ret == NO && self.outputProcessor.errorDetectedOnLastOutput == NO && self.outputProcessor.lastOutputWithoutMatch.length > 0 )
147-
{
148-
[ [ SKShell currentShell ] printInfoMessage: @"Last output fro xcodebuild:\n %@", self.outputProcessor.lastOutputWithoutMatch ];
149-
}
150-
else if( ret == NO && self.outputProcessor.errorDetectedOnLastOutput == NO && self.outputProcessor.lastOutput.length > 0 )
146+
if( ret == NO && self.outputProcessor.errorDetectedOnLastOutput == NO && self.outputProcessor.lastOutput.length > 0 )
151147
{
152148
[ [ SKShell currentShell ] printInfoMessage: @"Last output fro xcodebuild:\n %@", self.outputProcessor.lastOutput ];
153149
}

xrun/Classes/XRXcodeOutputProcessor.h

-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ NS_ASSUME_NONNULL_BEGIN
4242
@property( atomic, readonly ) BOOL hasAnalyzerWarnings;
4343
@property( atomic, readonly ) BOOL hasStandardErrorOutput;
4444
@property( atomic, readonly, nullable ) NSString * lastOutput;
45-
@property( atomic, readonly, nullable ) NSString * lastOutputWithoutMatch;
4645
@property( atomic, readonly ) BOOL errorDetectedOnLastOutput;
4746
@property( atomic, readonly, nullable ) NSString * standardErrorOutput;
4847

xrun/Classes/XRXcodeOutputProcessor.m

-17
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ @interface XRXcodeOutputProcessor()
4242
@property( atomic, readwrite, assign ) BOOL hasErrors;
4343
@property( atomic, readwrite, assign ) BOOL hasStandardErrorOutput;
4444
@property( atomic, readwrite, strong, nullable ) NSString * lastOutput;
45-
@property( atomic, readwrite, strong, nullable ) NSString * lastOutputWithoutMatch;
4645
@property( atomic, readwrite, assign ) BOOL errorDetectedOnLastOutput;
4746
@property( atomic, readwrite, strong ) dispatch_queue_t queue;
4847
@property( atomic, readwrite, strong ) NSDictionary< NSString *, NSArray< XRXcodeMessageMatcher * > * > * matchers;
@@ -198,22 +197,6 @@ - ( void )processMatchesInString: ( NSString * )str
198197
{
199198
self.hasAnalyzerWarnings = YES;
200199
}
201-
202-
if( match )
203-
{
204-
self.lastOutputWithoutMatch = nil;
205-
}
206-
else
207-
{
208-
if( self.lastOutputWithoutMatch == nil )
209-
{
210-
self.lastOutputWithoutMatch = str;
211-
}
212-
else
213-
{
214-
self.lastOutputWithoutMatch = [ self.lastOutputWithoutMatch stringByAppendingString: str ];
215-
}
216-
}
217200
}
218201
}
219202
}

0 commit comments

Comments
 (0)