Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py-frozenlist: fix build with new pythons on old systems #26752

Closed
wants to merge 1 commit into from

Conversation

barracuda156
Copy link
Contributor

Description

Fix

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6
Xcode 3.2

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@tobypeterson for port py-frozenlist.

@tobypeterson
Copy link
Contributor

I don't really love this approach, I'm curious how this impacts building on current versions of macOS/Xcode, which default to C17.

@barracuda156
Copy link
Contributor Author

barracuda156 commented Dec 6, 2024

@tobypeterson I works fine, which is seen both from CI here and from multiple non-Python ports which use this flag.

However, fixing this via Python PG is a better way, it is impractical to add identical per-port fixes. So I close this in favor of a PR for PG: #26830

@tobypeterson
Copy link
Contributor

Right, I'm not suggesting that it won't build - but building with an older C standard can slightly affect things, though usually in relatively meaningless ways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: bugfix
Development

Successfully merging this pull request may close these issues.

3 participants