Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Make ImageMagick Adapter compatible with php8 (Implicit conversion from float to int) #39402

Open
5 tasks done
m2-assistant bot opened this issue Nov 26, 2024 · 2 comments · May be fixed by #37362
Open
5 tasks done

[Issue] Make ImageMagick Adapter compatible with php8 (Implicit conversion from float to int) #39402

m2-assistant bot opened this issue Nov 26, 2024 · 2 comments · May be fixed by #37362
Assignees
@Bashev
Labels
Area: Framework Component: Framework/Code Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@m2-assistant
Copy link

m2-assistant bot commented Nov 26, 2024

This issue is automatically created based on existing pull request: #37362: Make ImageMagick Adapter compatible with php8 (Implicit conversion from float to int)

Sometimes when dimensions of the images are calculated they can comes as float numbers which cannot not be implicitly rounded and throws an error.

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Nov 26, 2024
@m2-assistant m2-assistant bot linked a pull request Nov 26, 2024 that will close this issue
Open
6 tasks
@engcom-Dash engcom-Dash added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Framework Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: Framework/Code labels Nov 26, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-13417 is successfully created for this GitHub issue.

@m2-assistant M2 Assistant
Copy link
Author

m2-assistant bot commented Nov 26, 2024

✅ Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bashev Bashev

Labels
Area: Framework Component: Framework/Code Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Milestone
No milestone
3 participants
@Bashev @engcom-Dash @github-jira-sync-bot