Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta Product Link is mapped to Admin URL by default, not front-end URL. #48

Closed
william-gooch opened this issue Dec 11, 2023 · 7 comments · May be fixed by #58
Closed

Meta Product Link is mapped to Admin URL by default, not front-end URL. #48

william-gooch opened this issue Dec 11, 2023 · 7 comments · May be fixed by #58

Comments

@william-gooch
Copy link

Summary (*)

When attempting to upload products into a Meta product feed, the default mapping for the Link field corresponds to the admin URL for that product, I imagine the one given by the getProductUrl function used here:

meta-for-magento2/app/code/Meta/Catalog/Model/Product/Feed/Builder.php

Lines 250 to 253 in e2a98a3

$parentUrl = $product->getParentProductUrl();
// use parent product URL if a simple product has a parent and is not visible individually
$url = (!$product->isVisibleInSiteVisibility() && $parentUrl) ? $parentUrl : $product->getProductUrl();
return $this->builderTools->replaceLocalUrlWithDummyUrl($url);

Surely it would make more sense for the default to be mapped to the frontend URL? While it's possible to use a post-process step to just find-and-replace on the URL it probably shouldn't be necessary.
@vncnt-mb
Copy link

Same problem here (tested 1.2.1 to 1.2.5 & Magento 2.4.6 - 2.4.6-p3)
On my side, only appears when child product (of parent configurable product) is not visible individually.

@Bashev
Copy link

Bashev commented Dec 21, 2023 •
edited
Loading

Fixed in #22

@william-gooch
Copy link
Author

Does this PR fix that issue? To me it looks like it only affects product images, not the product link itself.

@ptrdelgado2207
Copy link

is there any solution to this problem? since in dynamic ads, the URLs are wrong

@vncnt-mb
Copy link

vncnt-mb commented Feb 1, 2024

Do you have any updates on this?
We can't use dynamic ads on Facebook & Instagram at the moment since the problem occurs

All our products are refused because their links are invalid!

@ptrdelgado2207
Copy link

is there any solution to this problem?

@Bashev Bashev mentioned this issue Mar 15, 2024
Open
4 tasks
@zlik
Copy link
Contributor

zlik commented Nov 26, 2024

Fixed in 1.3.5, closing the issue.

@zlik zlik closed this as completed Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

get parent url if is available. Bashev/meta-for-magento2
5 participants
@zlik @Bashev @ptrdelgado2207 @william-gooch @vncnt-mb