Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: PDP add to cart action will refetch the query getProductDetailForProductPage #4288

Open
8 tasks
huykon opened this issue Jul 2, 2024 · 3 comments
Open
8 tasks
Assignees
Labels

Comments

@huykon
Copy link
Contributor

huykon commented Jul 2, 2024

Describe the bug
as the title, when we click add to cart on PDP, after added the PDP will re-render, don't know why

To reproduce

Steps to reproduce the behavior:

  1. Go to 'PDP'
  2. Open the network tab of your browser
  3. Click on 'Add to cart'
  4. See the query getProductDetailForProductPage re-call

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots

image

video screenshot
Screencast from 02-07-2024 14:39:06.webm

Possible solutions

Add any ideas about possible solutions to the problem here.

Debug Report

Paste the output of yarn build:report, and any other context about the problem, here.

Please complete the following device information:

  • Device [e.g. iPhone6, PC, Mac, Pixel3]:
  • Browser [e.g. Chrome, Safari]:
  • Browser Version [e.g. 22]:
  • Magento Version [e.g Adobe Commerce 2.4]:

Please let us know what packages this bug is in regards to:

  • venia-concept
  • venia-ui
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
  • create-pwa
@huykon huykon added the bug Something isn't working label Jul 2, 2024
Copy link

m2-assistant bot commented Jul 2, 2024

Hi @huykon. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.
Add a comment to assign the issue: @magento I am working on this


Join Magento Community Engineering Slack and ask your questions in #github channel.

@glo82145
Copy link
Collaborator

@adobe export issue to JIRA project PWA as Bug

@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/PWA-3365 is successfully created for this GitHub issue.

@del15881 del15881 self-assigned this Oct 18, 2024
@github-jira-sync-bot github-jira-sync-bot added needs-triage A pull request or issue that needs to be triaged prior to being synced to JIRA Progress: ready for grooming and removed Progress: ready for grooming needs-triage A pull request or issue that needs to be triaged prior to being synced to JIRA labels Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants