Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jack - fix tiff unpacking issue for IMAT #2193

Open
JackEAllen opened this issue May 8, 2024 · 1 comment · May be fixed by #2194
Open

Jack - fix tiff unpacking issue for IMAT #2193

JackEAllen opened this issue May 8, 2024 · 1 comment · May be fixed by #2194
Assignees
Labels
Duration: short Up to half day - amount of work estimated Type: Bug

Comments

@JackEAllen
Copy link
Collaborator

IMAT dropped by on the 3rd May to let me know that the tiff unpacking script was not working as expected compared to IimageJ. The output values produced by the utility script were slightly off.

I suspect there is an incorrect type conversion causing this bug.

Additionally, IMAT asked for some added clarification about whether the script creates a new director if the directory does not exist.

  • Resolve incorrect values from being written during unpacking
  • Add additional documentation to script file to describe usage
  • Add an additional method to log the date and time and whether or not the script was successful at writing all files along and the output file location files have been written too.
@JackEAllen JackEAllen self-assigned this May 8, 2024
@JackEAllen JackEAllen converted this from a draft issue May 8, 2024
@JackEAllen JackEAllen added Type: Bug Duration: short Up to half day - amount of work estimated labels May 8, 2024
@JackEAllen JackEAllen moved this from Todo to Review in Mantid Imaging Work May 13, 2024
@JackEAllen JackEAllen moved this from Review to Todo in Mantid Imaging Work May 16, 2024
@JackEAllen
Copy link
Collaborator Author

IMAT have mentioned that they noticed with a dataset that they experienced negative values. This issue is not pending on receiving the dataset IMAT experienced negative values with to try and replicate. therefore placing this issue in Impeded for the time being.

@JackEAllen JackEAllen moved this from Todo to Impeded in Mantid Imaging Work May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duration: short Up to half day - amount of work estimated Type: Bug
Projects
Status: Impeded
Development

Successfully merging a pull request may close this issue.

1 participant