Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AutoColorMenu and BadDataOverlay should be abstract base classes #2373

Open
samtygier-stfc opened this issue Nov 12, 2024 · 0 comments · May be fixed by #2374
Open

AutoColorMenu and BadDataOverlay should be abstract base classes #2373

samtygier-stfc opened this issue Nov 12, 2024 · 0 comments · May be fixed by #2374
Assignees
@samtygier-stfc
Labels
Type: Improvement

Comments

@samtygier-stfc
Copy link
Collaborator

Desired Behaviour

Use abc.ABC to make AutoColorMenu and BadDataOverlay into abstract base classes. The methods that they need from the image view can be abstractmethods.

A slight complication is pythons metaclass rules, so a derived metaclass will be needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samtygier-stfc samtygier-stfc

Labels
Type: Improvement
Projects
Mantid Imaging Work
Status: Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make image view mixins into abstract base classes mantidproject/mantidimaging
1 participant
@samtygier-stfc