Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify datasets 9: Remove MixedDataset #2401

Merged
merged 5 commits into from
Nov 20, 2024
Merged

Conversation

samtygier-stfc
Copy link
Collaborator

@samtygier-stfc samtygier-stfc commented Nov 15, 2024

Issue

Work on #2199

Description

Removes the MixedDataset

Changes the last few uses to Dataset

Testing

This updates relevant tests, and removes specific MixedDataset tests

Acceptance Criteria

Check loading a datatset
Opening the spectrum viewer and changing datasets
In main window, right click on an image and do "Duplicate whole data" and "Duplicate current ROI of data"

Documentation

Not yet

@coveralls
Copy link

Coverage Status

coverage: 74.217% (-0.003%) from 74.22%
when pulling 38fc0bb on 2199-unify-datasets-9
into 507d6e8 on main.

@samtygier-stfc samtygier-stfc marked this pull request as ready for review November 15, 2024 16:01
@JackEAllen JackEAllen self-requested a review November 19, 2024 09:34
Copy link
Collaborator

@JackEAllen JackEAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see the MixedDataset erased from the codebase. Thanks for the final cleanup. The dataset unification ennealogy seems to be coming along nicely. I've manually tested and checked unit tests. Happy to approve

@JackEAllen JackEAllen added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit 6148227 Nov 20, 2024
8 checks passed
@JackEAllen JackEAllen deleted the 2199-unify-datasets-9 branch November 20, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants