Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid hillshade textures on firefox wayland + amdgpu #2810

Open
multun opened this issue Jul 6, 2023 · 1 comment
Open

invalid hillshade textures on firefox wayland + amdgpu #2810

multun opened this issue Jul 6, 2023 · 1 comment

Comments

@multun
Copy link

multun commented Jul 6, 2023

maplibre-gl-js version: 3.1.0

browser: Firefox 114

Steps to Trigger Behavior

  1. visit either the contour lines or 3d terrain demos in FF wayland + amdgpu

2023-07-06_16-07-1688655258
2023-07-06_16-07-1688655270

Link to Demonstration

https://maplibre.org/maplibre-gl-js-docs/example/contour-lines/

I started debugging the issue and narrowed it down to the draw call in renderHillshade.
On chromium, the hill texture is rendered by spector.js as follows:
2023-07-06_16-07-1688654935

On the other hand, on firefox, it seems to be corrupted:
2023-07-06_16-07-1688654945

The corrupted texture also explains why the 3D terrain is also affected

Some notes:

  • It may be a driver bug (if so, I'd be happy to follow up upstream once the issue is narrowed down further)
  • I can't find any other webgl program which exhibits the same issue
  • painter.style.map.terrain is null at https://github.com/maplibre/maplibre-gl-js/blob/main/src/render/draw_hillshade.ts#L54, both on firefox and chrome
  • this texture seems to be generated by prepareHillshade, so I'd assume it's somewhat likely the issue is related to this function
@HarelM
Copy link
Collaborator

HarelM commented Jul 7, 2023

There is a branch that addresses some firefox warnings: #2297 I don't know if it's related, but might worth to check.
Otherwise I have no clue how to debug/find the root cause for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants