- Fixes compilation warnings in Elixir 1.18 (🙏 @vrcca)
- Improves compilation times by limiting the amount of code generated by the decorator. (🙏 @vrcca)
- Update dependencies:
credo
,ex_doc
,excoveralls
- Update dependencies:
dialyxir
,ex_doc
,o11y
- Update o11y and credo dependencies
- Update dependencies
- Add pid as a default span attribute
- 🐞BUG FIX: v1.5.4 introduced a bug where exits were being caught and the span annotated, but then control flow continued as if the exit had not occurred. We now exit with the same reason that was caught, so control flow is unchanged.
- Decorator will catch throws as well as exits and add an error status to the span.
- Catch unhandled Erlang exits and add an error status to the span.
- Bumps o11y version to v0.2.4 which includes an
add_event
method that processes the attributes given to it the same waywith_span
does.
- Fixes a bug which included input parameters you didn't ask for in the span attributes.
- Fixes a bug with missing
attrs_version
- 🚨 The decorator now uses the
O11y.set_attribute(s)
functions to set attributes on spans. This means that the attribute processing logic that was here previously has been migrated there. However, there are some backwards incompatible changes listed below. - 🚨 The decorator no longer supports nested attributes in the
include
option. TheO11y
set_attribute
andset_attributes
functions should now be used to handle more complex attribute specifications. TheSpanAttributes
protocol in particular is what I recommend if you need to extract a subset of fields from an object. The example below will add onlyuser.id
anduser.name
to the span attributes.
defmodule User do
@derive {O11y.SpanAttributes, only: [:id, :name]}
defstruct [:id, :name, :email, :password]
end
defmodule UserFactory do
use OpenTelemetryDecorator
@decorate with_span("UserFactory.create", include: [:user])
def create() do
user = %User{id: 1, name: "Bob", email: "[email protected]", password: "secret"}
{:ok, user}
end
end
- 🚨 Changes the default attrs_version to "v2". You can override this with
config :open_telemetry_decorator, attrs_version: "v1"
, but that only affects usages ofAttribtues
directly. ⚠️ Changes AttributesV2 to use theO11y.set_attribute(s)
functions. The attribute processing logic that was here previously has been migrated there. However, there are some backwards incompatible changes listed below.⚠️ Changed functionality: theerror
attribute is no longer treated differently from other attributes. It will be namespaced or prefixed as expected. If you're using Honeycomb this field will be automatically derived from the span's status_code, so you don't need to (and probably shouldn't) set it manually. Instead, useO11y.set_error/1
to set the status code to "error" and message to the provided (string or exception) value.⚠️ Changed functionality: maps and structs given toAttributes.set/2
will be flattened and prefixed with the given name. e.g.
params = %{key: "value"}
Attributes.set(:params, params)
# Becomes
%{"params.key" => "value"}
- Updates O11y dependency to v0.1.4 to fix an issue with setting error messages on spans.
- Updates decorator to use the o11y version of start and end span
- Refactor tests to use
O11y.TestHelper
and the available structs for asserting on span conents.
Clean up after ourselves instead of right before setting the status
I didn't realize Span.end_span
does not change the current span, which is why when the parent catches the reraise it had the wrong span as the current span.
We're starting the span in a place where we can hold on to it so we can manually update the current span to the parent so that callers that aren't using the decorator have the correct current span.
Addresses an issue setting error status on parent spans after exception
When two functions that are decorated with the with_span function are nested and the child throws, the current span was not being set back to the parent as expected. Calling Tracer.set_status would attempt to set the status on the child span which has been closed at that point and fail meaning the parent's status would be undefined.
Adds the ability to pass links to a function decorated with with_span
or trace
. This is done by passing a links
option to the decorator.
The links
option should be the atom names of variables containing linked spans. You can create a link to a span with OpenTelemetry.link/1
e.g.
require OpenTelemetry.Tracer, as: Tracer
def parent do
parent_span = Tracer.start_span("parent")
link = OpenTelemetry.link(parent_span)
child(link)
end
@decorate with_span("child", links: [:parent_link])
def child(parent_link) do
# ...
:ok
end
- Adds a v2 of the attributes module and the ability to toggle between. The v2 version is more limited, but simpler and (hopefully) easier to understand.
- Changes with_span to use start/end span
Previously dyalizer would not error on invalid contracts for functions annotated with the decorator. presumably this was because the return actually happens in a closure.
So, for example, the following code would pass dialyzer successfully
@spec hello :: {:ok, :asdf}
@decorate with_span("hello")
def hello do
:world
end
After this change it fails as expected
lib/spec_demo.ex:17:invalid_contract
The @spec for the function does not match the success typing of the function.
Function:
SpecDemo.hello/0
Success typing:
@spec hello() :: :world
- Fixes a bug causing the attribute prefix to be appended twice when using the include option
- Update and remove unused dependencies
- Updates dependencies, notably minor versions of the opentelemetry api and sdk
mix hex.outdated
Dependency Current Latest Status
credo 1.7.0 1.7.1 Update possible
decorator 1.4.0 1.4.0 Up-to-date
dialyxir 1.3.0 1.4.1 Update possible
ex_doc 0.30.3 0.30.6 Update possible
excoveralls 0.16.1 0.17.1 Update not possible
opentelemetry 1.3.0 1.3.1 Update possible
opentelemetry_api 1.2.1 1.2.2 Update possible
opentelemetry_exporter 1.6.0 1.6.0 Up-to-date
- Fixes an issue with included input parameters not being recorded in the span attributes when an exception is raised. Included body parameters will still not be included since they are not available from the rescue block.
- Fixes an issue with error not being recorded in the span attributes when using
Attributes.set
since it was being passed as an atom.
- Do not prefix "error" attributes with the configured prefix since these have special meaning in open telemetry
- Bump opentelemetry_exporter from 1.4.1 to 1.5.0 by @dependabot in #111
- Ensure that keys are strings before we call Span.set_attributes (#114)
- Adds with_span decorator (delegates to trace, so you can use either)
- Ensure attributes set with the helper get prefixed
- Adds span set attribute helper that treats attributes the same way
:include
does (currentlyinspects
anything it doesn't know how to handle) (thanks @ulissesalmeida) - Updates :include attribute validator to allow nested string keys (thanks @leggebroten)
- Fixes an issue where indexing into a nested struct via
:include
would crash due to a*Struct* does not implement the Access behaviour
error - Protect against context corruption (thanks @leggebroten)
- You're now able to
:include
nested result elements e.g.include: [[:result, :name]]
- You're now able to index into string keyed maps e.g.
include: [[:user, "id"]]
- Complex object attributes (lists, maps, tuples, etc.) are now
inspect
ed rather than omitted from the trace - 🚨The default joiner for nested attributes is now
.
rather than_
e.g.user.id=1
rather thanuser_id=1
🚨- You can change this behavior via configuration e.g.
config :open_telemetry_decorator, attr_joiner: "_"
- You can change this behavior via configuration e.g.
Introduces a breaking (kind of) change. The API hasn't changed at all, but it will no longer overwrite function input parameters in the span attributes if they are rebound in the body of the function.
e.g. this param_override(3, 2)
will add x=3
to the span, where previously it would have been x=4
@decorate trace("param_override", include: [:x, :y])
def param_override(x, y) do
x = x + 1
{:ok, x + y}
end