From da91043da7d2148ef124db427c734c82bf3272fd Mon Sep 17 00:00:00 2001
From: denis kiplangat <50864893+Deniskiplangat@users.noreply.github.com>
Date: Sat, 30 Mar 2024 04:23:22 +0300
Subject: [PATCH] had to change select.js code so that it works

using the previous code i got this error

SqlError: (conn:-1, no: 45027, SQLState: HY000) Cannot add request to pool, pool is closed
sql: SELECT * from demo.contacts
    at Object.module.exports.createError (/home/camindo/Node/mariadbnodeconnection/node_modules/mariadb/lib/misc/errors.js:66:10)
    at /home/camindo/Node/mariadbnodeconnection/node_modules/mariadb/lib/pool.js:538:24 {
  sqlMessage: 'Cannot add request to pool, pool is closed',
  sql: 'SELECT * from demo.contacts',
  fatal: false,
  errno: 45027,
  sqlState: 'HY000',
  code: 'ER_POOL_ALREADY_CLOSED'
---
 javascript/query/select.js | 29 +++++++++++++++--------------
 1 file changed, 15 insertions(+), 14 deletions(-)

diff --git a/javascript/query/select.js b/javascript/query/select.js
index 8456551..d9c66c9 100644
--- a/javascript/query/select.js
+++ b/javascript/query/select.js
@@ -1,20 +1,21 @@
-const db = require("./db");
+const db = require('./db')
 
-async function asyncFunction() {
+async function asyncFunction(){
     try {
-        // Use pool.query to get all contacts
-        var rows = await db.pool.query("SELECT * FROM demo.contacts");
 
-        // Print list of contacts
-        for (i = 0, len = rows.length; i < len; i++) {
-            console.log(`(id=${rows[i].id}) ${rows[i].first_name} ${rows[i].last_name} <${rows[i].email}>`);
+        conn = await db.pool.getConnection()
+        var rows = await conn.query("SELECT * from demo.contacts")
+        
+        for (let i = 0; i < rows.length; i++) {
+            console.log(`(id=${rows[i].id}) ${rows[i].first_name} ${rows[i].last_name} <${rows[i].email}>`)
+            
         }
-    } catch (err) {
-        // Print errors
-        console.log(err);
-    } finally {
-		db.pool.end();
-	}
+    } catch (error) {
+        console.log(error)
+    } finally{
+        if (conn) await conn.release();
+        db.pool.end()
+    }
 }
 
-asyncFunction();
\ No newline at end of file
+asyncFunction()