Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in hostname handling behavior during IP entry #446

Closed
bbrauchl opened this issue Jul 8, 2024 · 0 comments · Fixed by #457
Closed

Regression in hostname handling behavior during IP entry #446

bbrauchl opened this issue Jul 8, 2024 · 0 comments · Fixed by #457
Labels
bug Something isn't working

Comments

@bbrauchl
Copy link

bbrauchl commented Jul 8, 2024

Moonlight Version

1.6.18

Device Type

webOS TV

Device Model

LG

Device OS

webOS 03.40.82

Host OS

None

Host Software

None

Host Setup

N/A

Bug Description

Add computer UI input no longer will accept a hostname as the input. (the OK button never becomes active)
This seems to be related to #354 where sockaddr_parse was introduced to validate this input in src/app/ui/launcher/add.dialog.c.

Reproduction Steps

  1. Add computer
  2. Attempt to enter a hostname

Expected Behavior

Hostname should be accepted

@bbrauchl bbrauchl added the bug Something isn't working label Jul 8, 2024
@mariotaku mariotaku linked a pull request Oct 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant