Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Test #1

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

CI Test #1

wants to merge 7 commits into from

Conversation

marip8
Copy link
Owner

@marip8 marip8 commented Feb 28, 2023

No description provided.

@marip8 marip8 force-pushed the update/ci branch 2 times, most recently from f7afc13 to e788b48 Compare February 28, 2023 23:50
@marip8
Copy link
Owner Author

marip8 commented Mar 2, 2023

@Levi-Armstrong I figured out a way to get ROS-independent builds with industrial CI (see here). This PR has been my test case to get it to work, and it succeeds for all but the code coverage job where we are providing a make argument for all of the targets. Do you know how to do this with colcon since it doesn't support the --make-args option?

@Levi-Armstrong
Copy link

Are you going to try an push your changes back?

@Levi-Armstrong
Copy link

Looking at colcons source code it suggest that you can set them using this environment variable MAKEFLAGS.

@marip8
Copy link
Owner Author

marip8 commented Mar 2, 2023

Are you going to try an push your changes back?

ros-industrial/industrial_ci#818

@marip8 marip8 closed this Jun 5, 2023
@marip8 marip8 reopened this Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants