Tray icon volume control

[Winterhuman]

Allowing the user to control the volume of Museeks using just the context menu of the tray icon, like how pavucontrol does it, would be a nice addition. It already has play, previous, and next options so volume control should fit in.

A full on volume bar would probably be too large, perhaps two buttons for volume up and down could be added in order to not increase the context menu's size drastically?

[martpie]

Hello 👋

Aren't you using the mpris module on Linux for this kind of controls?

[Winterhuman]

I was not aware of mpris and have just checked it out, it can address the issue, but, if play, previous, and next are already included in the context menu (even though mpris already covers those controls) why not add volume control alongside the existing controls that Museeks tray icon already has?

Not meaning to be demanding btw, just asking why some controls covered by mpris are included in the tray icon but not others.

[martpie]

So this is perfectly do-able and not to complex and a perfectly valid concern. The thing is tray menus tend to close once clicked. So to reduce a little bit the volume every time we click on "volume down" could get really tedious and not exactly the best user-experience.

I'd have to think a bit about this 🤔

[Winterhuman]

Ah, I hadn't considered clicking would hide the context menu, that is difficult to get around unless some form of "inhibit close" option is available for tray icons (Not to mention if all platforms even have this option).

The main reason I want it included was I often times run Museeks in the background and then an extra loud or extra quiet song plays and I have to adjust the volume frequently, technically not as much as an issue once this gets merged, but, that was my original reason for wanting this feature.

[martpie]

Ah interesting! Thank you for the feedback. Can you thumb-up #568 ? So I can keep track of what users need/want :)

I'll try to see how hard it can be to implement

[Winterhuman]

Sure thing! Eager to see Museeks improve in the near future

[Winterhuman]

I think I'm willing to drop this issue if you want to, the pull request I mentioned earlier pretty much removes the need to adjust the volume of each next song when Museeks is minimised, I'll leave it to you to close in case you believe this is a worthwhile feature for the tray icon.

[martpie]

After some research, I have decided to kill the tray feature. See my rationale in #686 :)