Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bullets are displaced by 1 tick #638

Open
12 of 13 tasks
RicochetYT opened this issue Mar 6, 2023 · 19 comments
Open
12 of 13 tasks

Bullets are displaced by 1 tick #638

RicochetYT opened this issue Mar 6, 2023 · 19 comments
Labels
bug Something isn't working needs triage Needs to be organized tf2 Related to the TF2 live version and TC2

Comments

@RicochetYT
Copy link

Description

Title says it all. Bullets are displaced by 1 tick upon firing.
I'm pretty sure this also occurs even with building from this repo, if it doesn't, I didn't notice it get fixed.
ValveSoftware/source-sdk-2013#442
ValveSoftware/Source-1-Games#4829
Sourcemod plugin that fixes the bug on the serverside (you need to update offsets for it to work)

I thought it would be worth putting this here, though it is an issue affecting all Source 1 games, to my knowledge. I already opened an issue in the ValveSoftware/Source-1-Games repo, but I thought I would put it here as well, hoping it has some chance of being included in the next TF2 update!

Checklist

  • None of the open or closed issues document this problem.
  • This is a bug, not a new idea.
  • This is objectively a bug, and not something that people commonly disagree on.
  • This issue occurs on the latest Team Comtress release, or the master branch.
  • This issue occurs on the latest vanilla TF2 update.
  • This bug is in the code of the game, not in the textures, sounds, or other resources.
  • This issue is listed on the Source 1 official bugtracker.
  • This issue occurs with DirectX level 100.
  • This issue occurs when using no custom content.
  • This issue occurs when using start_tf2.bat (or start_server.bat) with no custom launch options.
  • This issue occurs when using a listen server (using the map command ingame).
  • This issue occurs when using a dedicated server.
  • This bug is in the internal procedures or tooling (e.g. the build process).

Reproduction

  1. Load into a game (LAN or dedicated, doesn't matter.)
  2. Set host_timescale to a low value
  3. Move sideways at a fast speed, use noclip to exaggerate the displacement of the bullet
  4. Fire a shot and watch as it doesn't hit the enemy despite hovering over said enemies head (you can use external software to see tracers or whatever else can be used to show shots...)

Screenshots/Videos

https://www.youtube.com/watch?v=VPT0-CKODNc

https://www.youtube.com/watch?v=pr4EZ06mrpQ

Setup Details

Client Settings

  • Server or client: Both?
  • Operating system: Any
  • Team Comtress version: Any
  • Custom content: N/A
  • Launch options: N/A
@RicochetYT RicochetYT added bug Something isn't working needs triage Needs to be organized tf2 Related to the TF2 live version and TC2 labels Mar 6, 2023
@mastercoms
Copy link
Member

Would you be able to confirm this bug is fixed if a possible patch was made for it?

@RicochetYT
Copy link
Author

This bug was not fixed in live TF2, however, there is a Sourcemod plugin that is a bandaid fix for this issue.

If you're referring to TC2/tf2-patches, I have not tested whether or not this bug exists but I can almost guarantee it does. I will try testing it soon.

@mastercoms
Copy link
Member

I mean that if a patch were made for this bug, would you be able to reliably test?

@RicochetYT
Copy link
Author

Oh, yeah, it's pretty easy to test.

@RicochetYT
Copy link
Author

To elaborate on this, this bug is very easily replicable and is a consistent, every time issue when moving at any speed, the degree to which it affects shooting is just exaggerated with higher velocities on the localplayer.

@mastercoms
Copy link
Member

Can you please retest with 2.0.0-b1?

@RicochetYT
Copy link
Author

Sure

@RicochetYT
Copy link
Author

Can you please retest with 2.0.0-b1?

No, this issue is not fixed on 2.0.0-b1, I just tested on a dedicated and LAN server.

@mastercoms
Copy link
Member

Could you record a video of it in TC2?

@mastercoms
Copy link
Member

Please retest with 2.0.0-b2

@RicochetYT
Copy link
Author

Could you record a video of it in TC2?

Build 2.0.0-b1:

2023-04-14.16-00-48.mp4

Please retest with 2.0.0-b2

Build 2.0.0-b2:

2023-04-14.16-10-15.mp4

Sorry for the late reply, I've been busy today.

@RicochetYT
Copy link
Author

If you could add a debug command (if it doesn't already exist) to show a client eye-angle trace on shot compared to server eye-angles on shot (like in this video), it would probably make this easier to see.

@RicochetYT
Copy link
Author

RicochetYT commented Apr 14, 2023

Oh and I just found a new bug introduced most likely in 2.0.0-b2, seems like some odd rubber banding when firing, but it's inconsistently reproducible.

2023-04-14.16-20-22.mp4

@mastercoms
Copy link
Member

Thanks for testing, I will see what I can do

@RicochetYT
Copy link
Author

How it should look for reference (live TF2, scope removed for visibility, fixed with the plugin linked in the issue)

test.mp4

@mastercoms
Copy link
Member

I think now that it's a much better fix to make sure movement is not 1 tick behind, so I will try to fix that instead

@RicochetYT
Copy link
Author

If anyone was curious, this issue was (seemingly) fixed in Counter-Strike 2 (or more likely, Source 2 as a whole).
This is almost certainly not intentional or something that's impossible to fix.

@RicochetYT
Copy link
Author

If anyone was curious, this issue was (seemingly) fixed in Counter-Strike 2 (or more likely, Source 2 as a whole).
This is almost certainly not intentional or something that's impossible to fix.

I say "seemingly" because the bullet tracer + impact particles and hole are still skewed by your velocity in the direction you're moving on the client, but the server handles it perfectly and doesn't skew where you shot.

@XutaxKamay
Copy link

If anyone was curious, this issue was (seemingly) fixed in Counter-Strike 2 (or more likely, Source 2 as a whole).
This is almost certainly not intentional or something that's impossible to fix.

I say "seemingly" because the bullet tracer + impact particles and hole are still skewed by your velocity in the direction you're moving on the client, but the server handles it perfectly and doesn't skew where you shot.

Yep exactly, if you're ready to read wall of text; please checkout the two comments here, this is my view on this ValveSoftware/source-sdk-2013#442 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage Needs to be organized tf2 Related to the TF2 live version and TC2
Projects
None yet
Development

No branches or pull requests

3 participants