-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong fix #38
Comments
I met the same problem.
|
@ChenyuanHu or @doublex, would you open a Pull Request with the fix so that I can merge it ASAP? |
msva
added a commit
to msva/nginx-upload-progress-module
that referenced
this issue
May 28, 2019
Signed-off-by: Vadim A. Misbakh-Soloviov <[email protected]>
msva
added a commit
to msva/nginx-upload-progress-module
that referenced
this issue
Aug 14, 2022
Signed-off-by: Vadim A. Misbakh-Soloviov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
The commit "aa4e8b93558274a45387d215740a6bd4654148f4" has a bug.
If I upload a file, the code enters the first "if()", but not the second "if()", so
"up->rest" is zero, but "up->length" is not.
Therefore the module reports in the beginning 100% uploaded because
up->rest == 0.
Thanks a lot!
The text was updated successfully, but these errors were encountered: