Skip to content
This repository has been archived by the owner on Feb 3, 2021. It is now read-only.

Input character not deleted #200

Open
pikeas opened this issue Jul 17, 2019 · 2 comments
Open

Input character not deleted #200

pikeas opened this issue Jul 17, 2019 · 2 comments
Labels
Type: Bug Fix an existing bug

Comments

@pikeas
Copy link

pikeas commented Jul 17, 2019

Current Behavior
This is the inverse of #179.

The smallest reproducible case I've found so far is to:

  • cd into a directory which triggers the AWS module
  • press "g"
  • press < tab >
  • press < delete >

Notice that the "g" remains displayed on screen but is not actually present in the buffer.

Expected Behavior
The first input character should not be displayed when deleted.

Relevant Fish Configuration

set SPACEFISH_PROMPT_ORDER user dir host git package docker aws venv conda kubecontext exec_time battery vi_mode jobs char
set SPACEFISH_PROMPT_ADD_NEWLINE true

set -g fish_emoji_width 2

Environment

  • Spacefish version: 2.6.1
  • Fish version: 3.0.2
  • Fish plugin manager: fisher
  • Terminal emulator: iTerm 3.2.9
  • Operating system: OSX 10.14.5

Additional context/Screenshots

  • This happens with or without line_sep.
  • This does not happen if I change SPACEFISH_AWS_SYMBOL to a non-emoji.
  • Pasting the cloud emoji taken from the Spacefish function (☁️) into iTerm doesn't render well, but renders correctly when output by Spacefish.
  • The iTerm setting "Use Unicode version 9 widths" is checked.
  • Possibly related: Emoji issues in Fish 3.0 fish-shell/fish-shell#5583
@matchai matchai added the Type: Bug Fix an existing bug label Jul 17, 2019
@matchai
Copy link
Owner

matchai commented Jul 17, 2019

Hmm... My first thought as well was the strangeness that happens around emojis and fish. It looks like you covered your bases and made sure fish and iTerm play nicely with double-width emoji. 🤔

Could you please try using a terminal emulator like Hyper to reproduce the issue? That way we might be able to confirm that this issue is tied to iTerm.

@pikeas
Copy link
Author

pikeas commented Jul 17, 2019

The issue is reproducible in Hyper, including the rendering bug for the cloud emoji when pasted.

@matchai matchai added the Help Wanted Extra attention is needed label Jul 23, 2019
@matchai matchai removed the Help Wanted Extra attention is needed label May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Bug Fix an existing bug
Projects
None yet
Development

No branches or pull requests

2 participants