Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaw in BlackMATE theme for evolution mail client #311

Open
pkzc opened this issue Feb 11, 2024 · 9 comments
Open

Flaw in BlackMATE theme for evolution mail client #311

pkzc opened this issue Feb 11, 2024 · 9 comments

Comments

@pkzc
Copy link

pkzc commented Feb 11, 2024

Expected behaviour

All text in all windows, panels, etc. are readable in evolution.

Actual behaviour

When using the BlackMATE theme, the Description field on the General tab of an evolution calendar entry is shown in white letters on a practically white background, and is unreadable.

Line 24 in /usr/share/themes/BlackMATE/gtk-3.0/gtk-main.css of mate-themes-3.22.24-2.fc39.noarch is this:
@define-color view_color #ECECEC;
This is almost white, changing it to #232323 or similar solves the problem in evolution. It may cause regression somehere else, but I haven't noticed any so far.

Steps to reproduce the behaviour

Double click on a calendar entry to open it.

MATE general version

mate-desktop-1.26.2-1.fc39.x86_64

Package version

mate-themes-3.22.24-2.fc39.noarch

Linux Distribution

Fedora Linux 39

Link to bugreport of your Distribution (requirement)

https://gitlab.gnome.org/GNOME/evolution/-/issues/2649

@lukefromdc
Copy link
Member

lukefromdc commented Feb 11, 2024 via email

@lukefromdc
Copy link
Member

lukefromdc commented Feb 11, 2024 via email

@pkzc
Copy link
Author

pkzc commented Feb 11, 2024

I think evolution is just fine with that change. The real question seems to me whether it messes something up in some other application.

@lukefromdc
Copy link
Member

lukefromdc commented Feb 11, 2024 via email

@lukefromdc
Copy link
Member

That created a major problem in a test with gtk3-widget-factory

BlackMATE_test

A test: Do you also get the same issue in adwaita-dark? If you do, the issue is in evolution. If not, we need to identify
the offending widget by name or name of an ancestor so as to restrict the change to evolution only.

@pkzc
Copy link
Author

pkzc commented Feb 13, 2024

No, Adwaita-dark lends a readable look to evolution all over. That was why I reported to BlackMATE.

But then isn't it a problem with gtk3-widget-factory? It would look quite a bit strange to me if we had two glaring white patches in your picture, and kind of much more natural the present dark background with white or light gray letters.

@lukefromdc
Copy link
Member

lukefromdc commented Feb 13, 2024 via email

@pkzc
Copy link
Author

pkzc commented Feb 13, 2024

I tried it but I am unsure whether this is what is needed:
image
The object highlighted by the cursor is the offending element in evolution (the Description field on the General tab of an open evolution calendar entry).
evolution had been started with Adwaita-dark but I think it makes no difference if we are after the widget name.

@lukefromdc
Copy link
Member

lukefromdc commented Feb 13, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants