-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix -Werror=cast-function-type with GCC 8 #217
Conversation
rbuj
commented
Mar 3, 2019
travis fails in fedora:
|
Known issue |
Now, the build passed :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A build with my normal build options (not messing with -Werror) builds everything fine.
mate-search-tool runs as before
mate-disk-usage-analyzer runs as before
mate-system-log runs as before
mate-dictionary runs same as before both from the panel applet and from the command line. Note that if from the command line you look up something NOT in the database (e.g. the string "test2") and then afterwards run a valid lookup (I used the string "test") you get
(mate-dictionary:9199): Gdict-CRITICAL **: 17:03:45.914: _gdict_show_error_dialog: assertion 'GTK_IS_WIDGET (widget)' failed
both with this PR and with master, so for this PR it can be disregarded.
Build with |
3587f2e
to
f5833a6
Compare
In addition, it removes unnecessary function type casts like: (GDestroyNotify) g_object_unref (GDestroyNotify) g_free
f5833a6
to
74cfada
Compare