Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lazy evaluation for git provided properties #877

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

lazy evaluation for git provided properties #877

wants to merge 1 commit into from

Conversation

frawa
Copy link

@frawa frawa commented Jan 7, 2025 •
edited
Loading

Resolves #874.

@frawa frawa mentioned this pull request Jan 7, 2025
Open
@mathieucarbou
Copy link
Owner

Hello @frawa,
Thanks for starting such efforts.
Please make sure to use the code style present in the classes you modify and do not reformat ;-)
Happy new year!

@frawa frawa marked this pull request as ready for review January 8, 2025 08:39
@mathieucarbou
Copy link
Owner

... also do not forget to squash your commits ;-)

@frank-wagner-ibm
Squashed commit of the following:
865cdfb 
commit 3b0a2a1
Merge: aef796a fceb1b2
Author: Frank Wagner <[email protected]>
Date:   Wed Jan 8 09:40:06 2025 +0100

    Merge branch 'master' into lazy-properties

commit aef796a
Author: Frank Wagner <[email protected]>
Date:   Wed Jan 8 09:38:00 2025 +0100

    remove unnecessary diffs

commit 6fec332
Author: Frank Wagner <[email protected]>
Date:   Wed Jan 8 09:28:17 2025 +0100

    remove unnecessary diffs

commit 5f0de6d
Author: Frank Wagner <[email protected]>
Date:   Wed Jan 8 09:20:29 2025 +0100

    apply code style

commit 3288ad2
Author: Frank Wagner <[email protected]>
Date:   Wed Jan 8 09:18:02 2025 +0100

    apply code style

commit cd950ab
Author: Frank Wagner <[email protected]>
Date:   Wed Jan 8 09:12:40 2025 +0100

    apply code style

commit 8c0ca7d
Author: Frank Wagner <[email protected]>
Date:   Wed Jan 8 09:12:25 2025 +0100

    export intellij style as Eclipse format (suiteable for VS Code, too.)

commit 4434923
Author: Frank Wagner <[email protected]>
Date:   Wed Jan 8 08:57:26 2025 +0100

    cleanup and clearer memoization

commit f640a62
Author: Frank Wagner <[email protected]>
Date:   Wed Jan 8 08:56:59 2025 +0100

    cleanup

commit b74a0c1
Author: Frank Wagner <[email protected]>
Date:   Wed Jan 8 08:56:31 2025 +0100

    adjust tests to use lazy properties

commit 2d13252
Author: Frank Wagner <[email protected]>
Date:   Tue Jan 7 14:22:36 2025 +0100

    cleanup

commit abc8f7d
Author: Frank Wagner <[email protected]>
Date:   Tue Jan 7 14:19:22 2025 +0100

    simplify interface for providing lazy properties

commit fceb1b2
Merge: e821b2f d5d9dd0
Author: Jeremy Landis <[email protected]>
Date:   Mon Jan 6 21:09:42 2025 -0500

    Merge pull request mathieucarbou#875 from mathieucarbou/dependabot/maven/org.assertj-assertj-core-3.27.2

    Bump org.assertj:assertj-core from 3.27.1 to 3.27.2

commit d5d9dd0
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Jan 6 16:38:08 2025 +0000

    Bump org.assertj:assertj-core from 3.27.1 to 3.27.2

    Bumps [org.assertj:assertj-core](https://github.com/assertj/assertj) from 3.27.1 to 3.27.2.
    - [Release notes](https://github.com/assertj/assertj/releases)
    - [Commits](assertj/assertj@assertj-build-3.27.1...assertj-build-3.27.2)

    ---
    updated-dependencies:
    - dependency-name: org.assertj:assertj-core
      dependency-type: direct:development
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <[email protected]>

commit 3751bdc
Author: Frank Wagner <[email protected]>
Date:   Mon Jan 6 15:23:45 2025 +0100

    POC: lazy evaluation for git provided properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hazendaz hazendaz Awaiting requested review from hazendaz

@mathieucarbou mathieucarbou Awaiting requested review from mathieucarbou

At least 1 approving review is required to merge this pull request.

Assignees

@frawa frawa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Speed up resolution of git provided properties for header content
3 participants
@frawa @mathieucarbou @frank-wagner-ibm