Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): Timeline can still have missing events #4684

Open
Hywan opened this issue Feb 18, 2025 · 0 comments · May be fixed by #4694
Open

fix(sdk): Timeline can still have missing events #4684

Hywan opened this issue Feb 18, 2025 · 0 comments · May be fixed by #4694

Comments

@Hywan
Copy link
Member

Hywan commented Feb 18, 2025

Most of this story around the Timeline that has missing events is because gaps are loaded in the RoomEventCache but are not reflected in the Timeline. See #4632 for the whole story.

By the way, #4632 fixes the problem, but one subtle case can happen and recreate this behaviour:

  • open a room (so a Timeline, so a RoomEventCache)
  • the last chunk will be loaded by RoomEventCache
  • the sync happens, and receives a limited response
  • the RoomEventCache contains items, then a gap, then items
  • this gap isn't resolved

Solution: when a limited response is received, the RoomEventCache should reload/shrink to a single chunk. This is also required by some apps, like Element X Android, that needs to shrinks the RoomEventCache due to memory pressure and Timeline performance on some devices. One seed, two birds.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant