Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image and text preview #34

Open
mfendeksilverstripe opened this issue Feb 9, 2024 · 0 comments
Open

Image and text preview #34

mfendeksilverstripe opened this issue Feb 9, 2024 · 0 comments

Comments

@mfendeksilverstripe
Copy link
Collaborator

Image and text preview

It would be great to have the option to customise Link Icon and text in the preview. I suggest to use similar approach as the Summary component of the Elemental module. This allows the display of a single image and a single line of text. This should be enough to easily identify the managed items.

Screenshot 2023-12-13 at 8 55 05 AM

This is the React component Summary

Screenshot 2023-12-13 at 8 56 29 AM

I also suggest to add some interfaces for easy integration with the component. We've done this for elemental but this is custom code as the elemental module doesn't provide this. This is a much cleaner and easier way to managed React properties compared to just passing it via updateBlockSchema() as a array property.

Screenshot 2023-12-13 at 8 56 53 AM

Screenshot 2023-12-13 at 8 57 02 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant