-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
error pip install on windows #3
Comments
Hey @fvarno , sorry for the late reply. Thanks for reporting this. I've been working on a fix. Do you have time to clone down the branch fix-windows and try to install it locally using:
? |
Hey Max,
Actually, the PR I made does exactly that for you on GitHub servers automatically (and for free because the project is open-sourced).
It checks for multiple Python versions on Linux, Windows, and MacOS.
If all the installations go through and your syntax is according to PEP8, it gives you a little green check on your repo.
This is how most well-known Python projects of which I'm aware make releases.
Cheers,
Farshid
…________________________________
From: Max Fischer ***@***.***>
Sent: Thursday, January 12, 2023 3:15 PM
To: maxvfischer/askai ***@***.***>
Cc: Farshid Hajhashemi Varnosfaderani ***@***.***>; Mention ***@***.***>
Subject: Re: [maxvfischer/askai] error pip install on windows (Issue #3)
CAUTION: The Sender of this email is not from within Dalhousie.
Hey @fvarno<https://github.com/fvarno> , sorry for the late reply. Thanks for reporting this.
I've been working on a fix. Do you have time to clone down the branch fix-windows<https://github.com/maxvfischer/askai/tree/fix-windows> and try to install it locally using:
pip install .
?
—
Reply to this email directly, view it on GitHub<#3 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJTCRFY5DDELL7CUH5XKW5LWSBQ5RANCNFSM6AAAAAATLUYIKU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Yes, thanks for doing the PR! As this is new technology for me, I need to look through and understand everything before I merged, so I thought that it made sense to merge a fix for Windows first to not block the usage for Windows-users. When this is merged, I'm planing add CICD for the testing :) //Max |
I confirm that windows installation goes through for |
There is something wrong with PyPI installation for windows on version 1.0.3.
The text was updated successfully, but these errors were encountered: