Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#309] Add separate fields for dutch addresses #329

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[#309] Add separate fields for dutch addresses #329

wants to merge 7 commits into from

Conversation

danielmursa-dev
Copy link
Contributor

Fixes #309

@danielmursa-dev
[#309] Update model and migrations
add1d20 
[#309] Create and fix tests

[#309] Fix admin and schema
@danielmursa-dev danielmursa-dev force-pushed the feature/add-separate-fields-for-dutch-addresses branch from 2f31a2e to add1d20 Compare February 5, 2025 11:11
@danielmursa-dev danielmursa-dev changed the title Feature/add separate fields for dutch addresses [#309] Add separate fields for dutch addresses Feb 5, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.36%. Comparing base (e6a3ea4) to head (add1d20).
Report is 15 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #329      +/-   ##
==========================================
+ Coverage   97.10%   97.36%   +0.26%     
==========================================
  Files         179      191      +12     
  Lines        8671     9543     +872     
==========================================
+ Hits         8420     9292     +872     
  Misses        251      251

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

stevenbal
stevenbal requested changes Feb 6, 2025
View reviewed changes
src/openklant/components/klantinteracties/admin/partijen.py Show resolved Hide resolved
src/openklant/components/contactgegevens/mixins.py Outdated Show resolved Hide resolved
src/openklant/components/contactgegevens/mixins.py Outdated Show resolved Hide resolved
src/openklant/components/contactgegevens/mixins.py Outdated Show resolved Hide resolved
src/openklant/components/contactgegevens/mixins.py Outdated Show resolved Hide resolved
src/openklant/components/contactgegevens/mixins.py Outdated Show resolved Hide resolved
src/openklant/components/contactgegevens/mixins.py Outdated Show resolved Hide resolved
src/openklant/components/contactgegevens/openapi.yaml Outdated Show resolved Hide resolved
src/openklant/components/klantinteracties/models/mixins.py Outdated Show resolved Hide resolved
@danielmursa-dev
[#309] Update help_text
3c86bf5
@danielmursa-dev
[#309] Fix BetrokkeneAdmin
5208754
@danielmursa-dev
[#309] Create unique Prefixed_mixin for Adres fields
aba76eb 
[#309] Change huisnummer in charfield

[#309] Update migrations

[#309] Update migrations with handle_null_values

[#309] Fix tests

[#309] Migrations.RunPython.noop
@danielmursa-dev danielmursa-dev force-pushed the feature/add-separate-fields-for-dutch-addresses branch from bfd7486 to 32e4325 Compare February 11, 2025 15:24
@danielmursa-dev danielmursa-dev force-pushed the feature/add-separate-fields-for-dutch-addresses branch from 32e4325 to 798c9b2 Compare February 11, 2025 15:26
@danielmursa-dev danielmursa-dev added this to the Release 2.6.0 milestone Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextreme alextreme alextreme left review comments

@Floris272 Floris272 Awaiting requested review from Floris272

@annashamray annashamray Awaiting requested review from annashamray

@stevenbal stevenbal Awaiting requested review from stevenbal

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.6.0
Development

Successfully merging this pull request may close these issues.

Aparte velden voor Nederlandse adressen naast adresregel 1 t/m 3 voor buitenlandse adressen
4 participants
@danielmursa-dev @codecov-commenter @alextreme @stevenbal