Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/6 meertalige content #34

Merged
merged 17 commits into from
Feb 14, 2025
Merged

Feature/6 meertalige content #34

merged 17 commits into from
Feb 14, 2025

Conversation

Floris272
Copy link
Contributor

@Floris272 Floris272 commented Jan 24, 2025 •
edited
Loading

Changes

  • Adds Parler
  • Makes Product type translatable
  • Adds translatable Content Element model
  • Translate api response based on Accepted-Language header
  • adds actions to product type & content element serializers to modify translations
  • adds Wysimark editor

@Floris272 Floris272 self-assigned this Jan 24, 2025
This was linked to issues Jan 24, 2025
Verwijderen van Vragen en Antwoorden #30
Closed
Toelichting-velden, meertalige content (NL+EN) #6
Closed
@Floris272 Floris272 force-pushed the feature/6-meertalige-content branch 2 times, most recently from a7deec2 to 634cc12 Compare January 31, 2025 14:21
@Floris272 Floris272 linked an issue Jan 31, 2025 that may be closed by this pull request
WYSIWYG editor voor ProductContent #16
Closed
@Floris272 Floris272 force-pushed the feature/6-meertalige-content branch from c26b76e to 289b3ab Compare February 4, 2025 10:10
@Floris272
Copy link
Contributor Author

The actual package @wysimark/standalone is not build correctly so i have used wysimark-standalone. Another option would be to build it within open-producten.

Currently npm run build calls collect (similar to how Open Inwoner does it) that copies the js file from node_modules to src/open_producten/static.

@Floris272 Floris272 marked this pull request as ready for review February 4, 2025 10:18
@Floris272 Floris272 requested a review from Coperh February 4, 2025 10:18
Coperh
Coperh approved these changes Feb 13, 2025
View reviewed changes
Copy link

@Coperh Coperh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks mostly fine.

  • You could probably make the language API language simpler.
  • It is possible to create translations for unsupported language.
  • Content Label is not accessible via the API and is missing from the default admin index

src/open_producten/producttypen/models/producttype.py
default="",
help_text=_("Korte samenvatting van het product type."),
),
naam=models.CharField(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will throw str after migrating since neither will be defined but I guess if no one has an existing DB, it should be fine?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in my product change page threw an exception because of this

src/open_producten/producttypen/tests/test_prijs.py Show resolved Hide resolved
src/open_producten/utils/views.py Outdated Show resolved Hide resolved
src/open_producten/utils/views.py Outdated Show resolved Hide resolved
src/open_producten/utils/views.py Show resolved Hide resolved
src/open_producten/fixtures/default_admin_index.json Outdated Show resolved Hide resolved
src/open_producten/producttypen/tests/api/test_producttype.py Show resolved Hide resolved
src/open_producten/producttypen/views.py Show resolved Hide resolved
src/open_producten/producttypen/tests/api/test_content.py Show resolved Hide resolved
@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@Floris272 Floris272 merged commit 216608c into master Feb 14, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Coperh Coperh Coperh approved these changes

Assignees

@Floris272 Floris272

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Floris272 @codecov-commenter @Coperh