Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use memcached on Heroku #39

Closed
sbaer opened this issue Jul 10, 2020 · 3 comments
Closed

Use memcached on Heroku #39

sbaer opened this issue Jul 10, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@sbaer
Copy link
Member

sbaer commented Jul 10, 2020

Provide an option in our appserver caching to use memcached instead of our current in-memory cache. We would need to include something like the hash of a definition contents in the key so we don't get old cache results from a previous run of the appserver and an old GH definition.

Seems like we could check for a memcached environment variable on Heroku and if it exists use that instead of the in-memory cache.

@sbaer sbaer added the enhancement New feature or request label Jul 10, 2020
@fraguada
Copy link
Member

@fraguada
Copy link
Member

fraguada commented Sep 18, 2020

  • Seems like we could check for a memcached environment variable on Heroku and if it exists use that instead of the in-memory cache.
  • We would need to include something like the hash of a definition contents in the key so we don't get old cache results from a previous run of the appserver and an old GH definition. TODO

@fraguada
Copy link
Member

fraguada commented Oct 6, 2020

fixed in #51

@fraguada fraguada closed this as completed Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants