Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct BIC but wrong bank name is returned #225

Closed
n49o7 opened this issue Oct 8, 2024 · 3 comments · Fixed by #226
Closed

Correct BIC but wrong bank name is returned #225

n49o7 opened this issue Oct 8, 2024 · 3 comments · Fixed by #226

Comments

@n49o7
Copy link

n49o7 commented Oct 8, 2024

In the case below, the correct bank_code, branch_code and BIC are returned. However, the bank_name seems wrong.

image

A quick web search shows that this BIC is for Société Générale in France.

I wonder if this issue could be related: #91
@n49o7
Copy link
Author

n49o7 commented Oct 9, 2024 •
edited
Loading

So the BIC is correct but the name is wrong, due to this name being given in bank_registry/manual_fr.json at Line 2302. The BIC code for branch 06990 of bank 30003 is indeed SOGEFRPP, and the bank is Société Générale SA. The BIC code for Inter Europe Conseil SAS is INELFRPP, which I didn't find anywhere in the codebase.

@Natim
Copy link
Contributor

Natim commented Oct 9, 2024

Let's update the file if it is wrong indeed.

@n49o7
Copy link
Author

n49o7 commented Oct 9, 2024 •
edited
Loading

Inter Europe Conseil SAS is closed since 2019, though. Société Générale consolidated it.

@Natim Natim mentioned this issue Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix SOCIETE GENERALE name Natim/schwifty
2 participants
@Natim @n49o7