Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do you support reading of QR-coded binary data into e.g., Uint8Array? #734

Open
psvz opened this issue Apr 2, 2023 · 2 comments · May be fixed by #982
Open

Do you support reading of QR-coded binary data into e.g., Uint8Array? #734

psvz opened this issue Apr 2, 2023 · 2 comments · May be fixed by #982

Comments

@psvz
Copy link

psvz commented Apr 2, 2023

Your demo fails at the task hence the question. Example of QRs: https://stackoverflow.com/questions/37996101/storing-binary-data-in-qr-codes

@jrocha
Copy link

jrocha commented Oct 19, 2024

Just did some tests using binary data. It is not working as expected. It is building a binary string in such a way that is read as unicode. Seems it uses TextEncoder internally, that mishandle binary data.

@ferm10n ferm10n linked a pull request Mar 2, 2025 that will close this issue
@ferm10n
Copy link

ferm10n commented Mar 2, 2025

Just pushed up a PR to support this. You'd be able to create a QR code from gzip'd content or a protobuf encoded payload (our use case) or any other binary payload and scan it using this package.

It initially started as a patch file in our project but I figured it'd be worth it to share

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants